Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals#42091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
PaolaRuby wants to merge0 commits intosymfony:5.2fromPaolaRuby:5.2

Conversation

@PaolaRuby
Copy link
Contributor

@PaolaRubyPaolaRuby commentedJul 13, 2021
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#42076
LicenseMIT

When a command extends a class wich implements SignalableCommandInterface but the command has empty signals to dispatch, it still can be executed, It can be useful when the extension is not available and the command is necessary.
Also, it can be used like a workaround for support other environments, for example windows servers, they don't have pcntl extension

fredsal and erikn69 reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@PaolaRuby
Copy link
ContributorAuthor

I don't understandfabbot.io

@@ -502,12 +502,12 @@         $tester = new ApplicationTester($application);         $tester->run(['command' => 'foos:bar1'], ['decorated' => false]);         $this->assertSame('-                                                          -  There are no commands defined in the "foos" namespace.

Line 502 has no changes

@chalasr
Copy link
Member

Thanks for the PR.
Please ignore fabbot here (false positive - he probably drinks too much wine these times).

erikn69, OskarStark, and fredsal reacted with thumbs up emojifredsal reacted with laugh emojiPaolaRuby reacted with heart emoji

@OskarStarkOskarStark changed the title[ComponentConsole]Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signalsJul 13, 2021
@OskarStark
Copy link
Contributor

@chalasr is5.2 the right branch, shouldn't it be5.3? 🤔

PaolaRuby reacted with eyes emoji

@chalasr
Copy link
Member

@OskarStark I don't think so, 5.2 is not EOM yet and bugfixes must target the lowest branch where they apply

OskarStark, PaolaRuby, and fredsal reacted with thumbs up emoji

@fredsal
Copy link

I hope it can be merged before end of support

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Here are some comments, mostly cosmetic.
I checked out your patch locally and it works as expected 👍

@carsonbotcarsonbot changed the title[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signalsRun commands when implements SignalableCommandInterface without pcntl and they have'nt signalsJul 15, 2021
@carsonbotcarsonbot changed the titleRun commands when implements SignalableCommandInterface without pcntl and they have'nt signals[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signalsJul 15, 2021
@PaolaRuby
Copy link
ContributorAuthor

PaolaRuby commentedJul 15, 2021
edited
Loading

@chalasr@stof resolved, thanks for the corrections

@nicolas-grekas
Copy link
Member

Thank you@PaolaRuby.

PaolaRuby reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestJul 19, 2021
…terface without pcntl and they have'nt signals (PaolaRuby)This PR was squashed before being merged into the 5.2 branch.Discussion----------[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals| Q             | A| ------------- | ---| Branch?       | 5.2| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Fix [#42076](#42076)| License       | MITWhen a command extends a class wich implements SignalableCommandInterface but the command has empty signals to dispatch, it still can be executed, It can be useful when the extension is not available and the command is necessary.Also, it can be used like a workaround for support other environments, for example windows servers, they don't have pcntl extensionCommits-------ad63d0b [Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals
@nicolas-grekas
Copy link
Member

(now, it's GitHub who drank too much, marking this PR as closed while it was merged... 🥂 😄 )

chalasr, OskarStark, erikn69, and PaolaRuby reacted with laugh emoji

This was referencedJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

7 participants

@PaolaRuby@carsonbot@chalasr@OskarStark@fredsal@nicolas-grekas@stof

[8]ページ先頭

©2009-2025 Movatter.jp