Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals#42091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJul 13, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
PaolaRuby commentedJul 13, 2021
I don't understandfabbot.io Line 502 has no changes |
chalasr commentedJul 13, 2021
Thanks for the PR. |
OskarStark commentedJul 13, 2021
@chalasr is |
chalasr commentedJul 14, 2021
@OskarStark I don't think so, 5.2 is not EOM yet and bugfixes must target the lowest branch where they apply |
fredsal commentedJul 15, 2021
I hope it can be merged before end of support |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here are some comments, mostly cosmetic.
I checked out your patch locally and it works as expected 👍
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PaolaRuby commentedJul 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedJul 19, 2021
Thank you@PaolaRuby. |
…terface without pcntl and they have'nt signals (PaolaRuby)This PR was squashed before being merged into the 5.2 branch.Discussion----------[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals| Q | A| ------------- | ---| Branch? | 5.2| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | Fix [#42076](#42076)| License | MITWhen a command extends a class wich implements SignalableCommandInterface but the command has empty signals to dispatch, it still can be executed, It can be useful when the extension is not available and the command is necessary.Also, it can be used like a workaround for support other environments, for example windows servers, they don't have pcntl extensionCommits-------ad63d0b [Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals
nicolas-grekas commentedJul 19, 2021
(now, it's GitHub who drank too much, marking this PR as closed while it was merged... 🥂 😄 ) |
Uh oh!
There was an error while loading.Please reload this page.
When a command extends a class wich implements SignalableCommandInterface but the command has empty signals to dispatch, it still can be executed, It can be useful when the extension is not available and the command is necessary.
Also, it can be used like a workaround for support other environments, for example windows servers, they don't have pcntl extension