Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Contracts] add return types and bump to v3#42088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:6.0fromnicolas-grekas:contracts3
Jul 15, 2021

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.0
Bug fix?no
New feature?yes
Deprecations?no
Tickets#42058
LicenseMIT
Doc PR-

elazar reacted with thumbs up emoji
@nicolas-grekas
Copy link
MemberAuthor

PR ready!

@nicolas-grekas
Copy link
MemberAuthor

this should require psr/container 2.0

I agree, and I did the same for psr/cache, sticking to 3.0.
Now blocked bydoctrine/cache#382
/cc@derrabus

Copy link
Contributor

@TobionTobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but don't the test failures indicate a problem?

PHP Fatal error: Declaration of Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\FormLoginBundle\Controller\LoginController::getSubscribedServices() must be compatible with Symfony\Contracts\Service\ServiceSubscriberInterface::getSubscribedServices(): array in /home/runner/work/symfony/symfony/src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php on line 66

@derrabus
Copy link
Member

Thank you Nicolas.

@derrabusderrabus merged commitb28f7e7 intosymfony:6.0Jul 15, 2021
@nicolas-grekasnicolas-grekas deleted the contracts3 branchJuly 15, 2021 07:23
@fabpotfabpot mentioned this pull requestNov 5, 2021
derrabus added a commit that referenced this pull requestDec 20, 2023
This PR was merged into the 6.4 branch.Discussion----------[Contracts] Allow psr/container 1.1 again| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | N/A| License       | MITThe only difference between psr/container 1.1 and 2.0 is one additional return type on the `ContainerInterface::has()` method, seephp-fig/container@1.1.2...2.0.2This means that if a package is compatible with 2.0 already (== all implementations already have that return type), it remains compatible with 1.1. However, in#42088 we changed the composer.json of our service-contracts package and replaced `^1.1` with `^2.0`, dropping support for 1.1 although there was no need to do so.I'm migrating a larger application to Symfony 7 at the moment which also consumes various Laminas packages. Due to Laminas still being stuck on psr/container 1.1, I cannot upgrade to service-contracts 3 which in turn blocks my Symfony 7 upgrade.It would smoothen the upgrade path a lot for me, if we released a service-contracts 3.x that allows the installation of psr/container 1.1 again.Commits-------80d34d0 Allow psr/container 1.1 again
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@derrabus@stof@Tobion@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp