Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Contracts] add return types and bump to v3#42088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 13, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | #42058 |
| License | MIT |
| Doc PR | - |
bd68e60 to2891252Compare470b02d toc200b51Comparenicolas-grekas commentedJul 13, 2021
PR ready! |
Uh oh!
There was an error while loading.Please reload this page.
dddcc52 tocb120f4Comparenicolas-grekas commentedJul 13, 2021
I agree, and I did the same for psr/cache, sticking to 3.0. |
Tobion left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM but don't the test failures indicate a problem?
PHP Fatal error: Declaration of Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\FormLoginBundle\Controller\LoginController::getSubscribedServices() must be compatible with Symfony\Contracts\Service\ServiceSubscriberInterface::getSubscribedServices(): array in /home/runner/work/symfony/symfony/src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php on line 66
derrabus commentedJul 15, 2021
Thank you Nicolas. |
This PR was merged into the 6.4 branch.Discussion----------[Contracts] Allow psr/container 1.1 again| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Issues | N/A| License | MITThe only difference between psr/container 1.1 and 2.0 is one additional return type on the `ContainerInterface::has()` method, seephp-fig/container@1.1.2...2.0.2This means that if a package is compatible with 2.0 already (== all implementations already have that return type), it remains compatible with 1.1. However, in#42088 we changed the composer.json of our service-contracts package and replaced `^1.1` with `^2.0`, dropping support for 1.1 although there was no need to do so.I'm migrating a larger application to Symfony 7 at the moment which also consumes various Laminas packages. Due to Laminas still being stuck on psr/container 1.1, I cannot upgrade to service-contracts 3 which in turn blocks my Symfony 7 upgrade.It would smoothen the upgrade path a lot for me, if we released a service-contracts 3.x that allows the installation of psr/container 1.1 again.Commits-------80d34d0 Allow psr/container 1.1 again