Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] [Smsapi] fixed checking whether message is sent#42053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromdamlox:5.3
Aug 26, 2021

Conversation

@damlox
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

SmsAPI always return 200 status code even if we enter incorrect token.
The content is:{"error":101,"message":"Authorization failed"}.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a test case

@carsonbotcarsonbot changed the titlefixed checking whether message is sent[Notifier] fixed checking whether message is sentJul 10, 2021
@OskarStarkOskarStark changed the title[Notifier] fixed checking whether message is sent[Notifier] [Smsapi] fixed checking whether message is sentJul 10, 2021
$responseContent =$response->toArray(false);

thrownewTransportException(sprintf('Unable to send the SMS: "%s".',$error['message']),$response);
if ((isset($responseContent['error']) &&null !==$responseContent['error']) || (200 !==$response->getStatusCode())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

isset($foo['bar']) returns also true when the key exists but it's value is null.
You can remove the second assertion

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I need to confirm if the value is not null. Checking only if the key exists is not sufficient

@OskarStark
Copy link
Contributor

OskarStark commentedJul 28, 2021•
edited
Loading

I would really appreciate if you finish this PR and apply the comments. Thanks

@damlox
Copy link
ContributorAuthor

Unwound really appreciate if you finish this PR and apply the comments. Thanks

I'll finish the PR this weekend

OskarStark reacted with rocket emoji

@fabpot
Copy link
Member

Thank you@damlox.

@fabpotfabpot merged commit1e91b1a intosymfony:5.3Aug 26, 2021
@fabpotfabpot mentioned this pull requestAug 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@damlox@carsonbot@OskarStark@fabpot@jderusse
[8]ページ先頭
©2009-2025 Movatter.jp