Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] recover from failed deserializations#42032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJul 8, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#42031 |
| License | MIT |
| Doc PR |
| } | ||
| returnunserialize($entries); | ||
| returnunserialize($entries) ?: []; |
EmmanuelVellaJul 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unserialize can return various types (seehttps://www.php.net/manual/en/function.unserialize.php#refsect1-function.unserialize-returnvalues).
Maybe we should test the return value withis_array ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, the Store controls the serialization too. So if unserializing does not fail, we know that we have an array (unless you messed up with the files directly to change what is stored, but that's not supported by our implementation)
nicolas-grekas commentedJul 9, 2021
Thank you@xabbuh. |
EmmanuelVella commentedJul 10, 2021
Thank you@xabbuh ! |