Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fix save correct name in setDefaultCommand() for PHP8#42009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3froma1812:fix_issue_41942
Jul 8, 2021

Conversation

@a1812
Copy link
Contributor

@a1812a1812 commentedJul 6, 2021
edited
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41942
Doc PR

Fix save correct name in setDefaultCommand() for PHP8

@duboiss
Copy link
Contributor

I don't feel that this is fixing#41942 after testing on my local project (duboiss/sfcommand, php8 branch) your modifications.

@a1812
Copy link
ContributorAuthor

I don't feel that this is fixing#41942 after testing on my local project (duboiss/sfcommand, php8 branch) your modifications.

and nevertheless my test shows that everything is in order :)
image

duboiss reacted with heart emoji

@duboiss
Copy link
Contributor

My bad, I think I made a mistake between twogit clone. It's ok from my side too, nice job!

@fabpot
Copy link
Member

Thank you@a1812.

@fabpotfabpot merged commit4a03392 intosymfony:5.3Jul 8, 2021
@a1812a1812 deleted the fix_issue_41942 branchJuly 21, 2021 10:47
@fabpotfabpot mentioned this pull requestJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@a1812@duboiss@fabpot@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp