Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Revert "bug #41952 fix handling positional arguments"#41966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 3 commits intosymfony:4.4fromchalasr:revert-int-arg
Jul 4, 2021

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedJul 3, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Reverts#41952 as it breaks tests on 5.3 due to an implicit string cast:
We added thestring typehint to the$name argument in 5.x, removing it now to allow forstring|int would be a BC break which I don't think is worth it.

… (nicolas-grekas)"This reverts commite93f8c0, reversingchanges made toeb83be4.
@carsonbotcarsonbot added this to the4.4 milestoneJul 3, 2021
@carsonbotcarsonbot changed the titleRevert "bug #41952 [Console] fix handling positional arguments"[Console] Revert "bug #41952 fix handling positional arguments"Jul 3, 2021
@nicolas-grekas
Copy link
Member

Then we need to also revert the change on the interface, and I'm in favor of deprecating positions in hasArgument and in InputDefinition. The current behavior doesn't make sense when integers are passed. Can you give it a try?

chalasr reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@chalasr.

@nicolas-grekasnicolas-grekas merged commit2abf5a4 intosymfony:4.4Jul 4, 2021
@chalasrchalasr deleted the revert-int-arg branchJuly 4, 2021 09:36
@chalasr
Copy link
MemberAuthor

@nicolas-grekas It appears that handling positions in InputDefinition is required for parsing the raw input (forIS_ARRAY arguments especially), see e.g.

}elseif ($this->definition->hasArgument($c -1) &&$this->definition->getArgument($c -1)->isArray()) {
Nothing to do I'd say.

This was referencedJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp