Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] fix handling positional arguments#41952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedJul 3, 2021
Hey! I think@PatchRanger has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
chalasr approved these changesJul 3, 2021
Member
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd really appreciate a test case :)
MemberAuthor
nicolas-grekas commentedJul 3, 2021
Here you are, with a test case. |
nicolas-grekas added a commit that referenced this pull requestJul 4, 2021
…ents" (chalasr, nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[Console] Revert "bug#41952 fix handling positional arguments"| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Reverts#41952 as it breaks tests on 5.3 due to an implicit string cast:We added the `string` typehint to the `$name` argument in 5.x, removing it now to allow for `string|int` would be a BC break which I don't think is worth it.Commits-------6ac2776 [Console] Fix type annotation on InputInterface::hasArgument()9928be0 Revert "minor#41949 [Console] fix type annotations on InputInterface (nicolas-grekas)"8fc58aa Revert "bug#41952 [Console] fix handling positional arguments (nicolas-grekas)"
nicolas-grekas added a commit that referenced this pull requestJul 4, 2021
* 4.4: Fix SkippedTestSuite [Console] Fix type annotation on InputInterface::hasArgument() Revert "minor#41949 [Console] fix type annotations on InputInterface (nicolas-grekas)" [EventDispatcher] Correct the called event listener method case Add missing translations for Japanese. Revert "bug#41952 [Console] fix handling positional arguments (nicolas-grekas)" [Security] Don't skip UserPasswordValidatorTest [DI] CS fix [Console] fix handling positional arguments [Validator] add translation for Vietnamese Add Bulgarian translation for the validator
nicolas-grekas added a commit that referenced this pull requestJul 4, 2021
* 5.2: CS fix Missing translations from traits Fix SkippedTestSuite [Console] Fix type annotation on InputInterface::hasArgument() Revert "minor#41949 [Console] fix type annotations on InputInterface (nicolas-grekas)" [EventDispatcher] Correct the called event listener method case Add missing translations for Japanese. Revert "bug#41952 [Console] fix handling positional arguments (nicolas-grekas)" fix backport
nicolas-grekas added a commit that referenced this pull requestJul 4, 2021
* 5.3: CS fix Missing translations from traits Fix SkippedTestSuite [Console] Fix type annotation on InputInterface::hasArgument() Revert "minor#41949 [Console] fix type annotations on InputInterface (nicolas-grekas)" [EventDispatcher] Correct the called event listener method case [Serializer] Need to clear cache when updating Annotation Groups on Entities Add missing translations for Japanese. Revert "bug#41952 [Console] fix handling positional arguments (nicolas-grekas)" Fix test [Security] Don't skip UserPasswordValidatorTest [DI] CS fix [Console] fix handling positional arguments [Validator] add translation for Vietnamese Add Bulgarian translation for the validator fix backport [Console] fix type annotations on InputInterface
nicolas-grekas added a commit that referenced this pull requestJul 4, 2021
* 5.4: [FrameworkBundle] Add missing dep CS fix Missing translations from traits Fix SkippedTestSuite [Console] Fix type annotation on InputInterface::hasArgument() [Notifier] add Mailjet SMS bridge Revert "minor#41949 [Console] fix type annotations on InputInterface (nicolas-grekas)" [EventDispatcher] Correct the called event listener method case [Serializer] Need to clear cache when updating Annotation Groups on Entities Add missing translations for Japanese. Revert "bug#41952 [Console] fix handling positional arguments (nicolas-grekas)" Fix test [Security] Don't skip UserPasswordValidatorTest [DI] CS fix [Console] fix handling positional arguments Add TesterTrait::assertCommandIsSuccessful() helper [Validator] add translation for Vietnamese Add Bulgarian translation for the validator fix backport [Console] fix type annotations on InputInterface
This was referencedJul 26, 2021
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Follow up of#41949