In Symfony 6, we would be able to use typed properties. This is why I gave it a try and migrated all private properties of my favorite component to evaluate how the path might look like and what we have to watch out for.

Why only private properties? Well because adding types here is mostly safe. If I add a type to a protected/public property, I might break existing code that overrides that property.

One important thing we have to watch out for is the uninitialized state that a typed property has until we assign a value to it for the first time. As long as that property is in that state, reading it will trigger an error. However, callingisset() is safe and access to those properties can be safeguarded with?? and??=.

An untyped property would implicitly be initialized withnull and our existing code often relies on that behavior.

Another pitfall is thecallable pseudo-type: PHP does not allow us to assign it to a property. I've usedstring|array|object instead, but I'm open for better ideas.

I used PhpStorm for most of the work, but I needed to adjust the code afterwards. I've searched the code (except theTests folder) for forprivate $, opened each file and let PhpStorm infer all property types. Findings:

• If PhpStorm inferred a type, it was the correct one.
• PhpStorm is bad at detecting the nullability of a property.
• PhpStorm won't help you deal with uninitialized properties and it won't add a= null initializer.

The manual work was mainly look at all the places where a property is accessed and check if an implicitnull initialization was expected or ifnull is assigned directly to the property. My goal here was to avoid making a property nullable if possible.

I sometimes moved an initialization with a constant value from the constructor to the property declaration to make the initialization more obvious. I think we can backport that if we want to keep the diff small.

What do you think? Shall we go with types properties?