Jul 4, 2021 · Jun 29, 2021 · Jul 2, 2021 · Jul 3, 2021
diff --git a/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php b/src/Symfony/Component/EventDispatcher/DependencyInjection/RegisterListenersPass.php

                if (!isset($event['method'])) {
                    $event['method'] = 'on'.preg_replace_callback([
                        '/(?<=\b)[a-z]/i',
                        '/(?<=\b|_)[a-z]/i',
                        '/[^a-z0-9]/i',
                    ], function ($matches) { return strtoupper($matches[0]); }, $event['event']);
                    $event['method'] = preg_replace('/[^a-z0-9]/i', '', $event['method']);
diff --git a/...Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php b/...Symfony/Component/EventDispatcher/Tests/DependencyInjection/RegisterListenersPassTest.php
        $container->register('foo', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
        $container->register('bar', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
        $container->register('baz', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'event']);
        $container->register('zar', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar_zar']);
        $container->register('event_dispatcher', \stdClass::class);

        $registerListenersPass = new RegisterListenersPass();
                    0,
                ],
            ],
            [
                'addListener',
                [
                    'foo.bar_zar',
                    [new ServiceClosureArgument(new Reference('zar')), 'onFooBarZar'],
                    0,
                ],
            ],
        ];
        $this->assertEquals($expectedCalls, $definition->getMethodCalls());
    }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -81,7 +81,7 @@ public function process(ContainerBuilder $container)

		if (!isset($event['method'])) {
		$event['method'] = 'on'.preg_replace_callback([
		'/(?<=\b)[a-z]/i',
		'/(?<=\b\|_)[a-z]/i',
		'/[^a-z0-9]/i',
Copy link Contributor ro0NLJul 2, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. btw this 2nd regex is a leftover fromhttps://github.com/symfony/symfony/pull/1162/files it seems, where it was replaced with empty string which now happens at L87, this happened with refactoring likely. AFAIK it's redundant 👼 Copy link ContributorAuthor jjsty1eJul 3, 2021 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. it confused me too, but I'm not sure we can remove
		], function ($matches) { return strtoupper($matches[0]); }, $event['event']);
		$event['method'] = preg_replace('/[^a-z0-9]/i', '', $event['method']);
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -175,6 +175,7 @@ public function testInvokableEventListener()
		$container->register('foo', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
		$container->register('bar', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'foo.bar']);
		$container->register('baz', InvokableListenerService::class)->addTag('kernel.event_listener', ['event' => 'event']);
		$container->register('zar', \stdClass::class)->addTag('kernel.event_listener', ['event' => 'foo.bar_zar']);
		$container->register('event_dispatcher', \stdClass::class);

		$registerListenersPass = new RegisterListenersPass();
Expand DownExpand Up		@@ -206,6 +207,14 @@ public function testInvokableEventListener()
		0,
		],
		],
		[
		'addListener',
		[
		'foo.bar_zar',
		[new ServiceClosureArgument(new Reference('zar')), 'onFooBarZar'],
		0,
		],
		],
		];
		$this->assertEquals($expectedCalls, $definition->getMethodCalls());
		}
Expand Down