Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] fix #41891 Save hashed tokenValue in RememberMe cookie#41897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.3fromqurben:symfony/5.3
Jul 16, 2021

Conversation

@qurben
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41891
LicenseMIT

The hashed tokenValue is expected in the RememberMe cookie. This was not the case when this branch was executed.

@qurben
Copy link
ContributorAuthor

I am not sure if it is possible to create a test for this.testConsumeRememberMeCookieValid could test that the value that is passed to the tokenProvider mock is also found in the cookie, but when the mock is called the cookie is not yet set.

@chalasr
Copy link
Member

Thanks for fixing this bug@qurben.

Seldaek reacted with thumbs up emojiSeldaek and alexandresalome reacted with hooray emoji

@chalasrchalasr merged commit643e29a intosymfony:5.3Jul 16, 2021
@fabpotfabpot mentioned this pull requestJul 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse approved these changes

@chalasrchalasrchalasr approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

+1 more reviewer

@SeldaekSeldaekSeldaek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@qurben@chalasr@Seldaek@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp