Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Hide security toolbar if no firewall matched#41874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromwouterj:hide-security-toolbar
Jul 2, 2021

Conversation

@wouterj
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41242 (comment)
LicenseMIT
Doc PR-

As reported by@pavol-tk, we currently show a red Security block in the toolbar if no firewall matched. I think we should instead leave the block out of the toolbar, just like we do with all other elements if there is no data for that request.

cc@javiereguiluz as you're the best in these UX like decisions :)

jvasseur reacted with thumbs up emoji
@derrabus
Copy link
Member

I think that this change is a good idea. I'm unsure about merging it as a bugfix, though.

@fabpot
Copy link
Member

I agree with@derrabus, this should target 5.4 instead (I would have been ok-ish if this was a "behavior" that changed in 5.3, but here, the behavior has been consistent since a long time).

wouterj and derrabus reacted with thumbs up emoji

@chalasr
Copy link
Member

rebase needed

@wouterjwouterjforce-pushed thehide-security-toolbar branch froma2e77cd to29706eaCompareJune 27, 2021 15:53
@wouterjwouterjforce-pushed thehide-security-toolbar branch from29706ea to75590aaCompareJuly 1, 2021 18:11
@fabpot
Copy link
Member

Thank you@wouterj.

@wouterjwouterj deleted the hide-security-toolbar branchJuly 2, 2021 10:50
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@94noni94noni94noni approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@wouterj@derrabus@fabpot@chalasr@94noni@xabbuh@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp