Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add TesterTrait::assertCommandIsSuccessful() helper#41851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
19059dc to01db8f0Comparecarsonbot commentedJun 25, 2021
Hey! I think@Jean85 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
yoannrenard commentedJun 25, 2021
It looks like tests on Travis with PHP 8.0 fail as they are run against |
xabbuh commentedJun 26, 2021
The |
0d18b9c todb39567Compareyoannrenard commentedJun 26, 2021
Thanks for your help@xabbuh |
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR. I don't see any backward incompatible change here.
LGTM but the CHANGELOG file needs to be updated
yoannrenard commentedJun 27, 2021
Updated@chalasr |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rebase needed
| 5.4 | ||
| --- | ||
| * Add`TesterTrait::assertCommandIsSuccessful()` to test command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing space at start of line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch
| "symfony/expression-language":"^4.4|^5.0|^6.0", | ||
| "symfony/config":"^4.4|^5.0|^6.0", | ||
| "symfony/console":"^4.4|^5.0|^6.0", | ||
| "symfony/console":"^5.4|^6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the conflict line should also be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
| "symfony/asset":"^5.3|^6.0", | ||
| "symfony/browser-kit":"^4.4|^5.0|^6.0", | ||
| "symfony/console":"^5.2|^6.0", | ||
| "symfony/console":"^5.4|^6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the conflict line should be updated too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
4d7badc to434e3d2Compare434e3d2 to6221527Comparechalasr commentedJul 3, 2021
Thank you@yoannrenard. |
This PR introduces a new helper TesterTrait::assertCommandIsSuccessful() that aims to help testing the result of a command.
This is inspired byBrowserKitAssertionsTrait::assertResponseIsSuccessful