Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Add commented base64 version of secrets' keys#41786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromnicolas-grekas:fwb-secrets-b64
Jun 23, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedJun 22, 2021•
edited
Loading

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

I'm proposing this minor DX improvement: adding the base64-encoded version of secrets' keys in their source file.
Here is an example output. L3 is the new one.

<?php// dev.decrypt.private on Tue, 22 Jun 2021 15:30:09 +0200// SYMFONY_DECRYPTION_SECRET=GpvL44UBcwxbXrJHc2dHK+zFVssHsQk04hyzXBjBum81lNFTuHIVldehxdgdDJ/anfrTD4eYN3Wn5H7BW2a1Kg==return"\x1A\x9B\xCB\xE3\x85\x01s\x0C\x5B\x5E\xB2GsgG\x2B\xEC\xC5V\xCB\x07\xB1\x094\xE2\x1C\xB3\x5C\x18\xC1\xBAo5\x94\xD1S\xB8r\x15\x95\xD7\xA1\xC5\xD8\x1D\x0C\x9F\xDA\x9D\xFA\xD3\x0F\x87\x987u\xA7\xE4~\xC1\x5Bf\xB5\x2A";

Should make it a bit easier to populate the SYMFONY_DECRYPTION_SECRET env var by enabling copy/pasting.

@stof
Copy link
Member

do we need quoting the value to avoid issues with= in the base64 alphabet ?

@nicolas-grekas
Copy link
MemberAuthor

do we need quoting the value to avoid issues with = in the base64 alphabet ?

we don't have to, I don't think a= in the value is an issue.

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for 5.4

@fabpotfabpot changed the base branch from4.4 to5.4June 23, 2021 09:39
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@jderussejderussejderusse approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@stof@fabpot@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp