Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] fix removing "action" from route names#41782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tobion merged 1 commit intosymfony:5.4fromnicolas-grekas:fwb-route-name
Jul 7, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedJun 22, 2021
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40024
LicenseMIT
Doc PR-

@ro0NL
Copy link
Contributor

should we change default names in a patch release?

@stof
Copy link
Member

This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release

@ro0NL
Copy link
Contributor

also, from my experience, dereferencing virtual route names is pure pain :D

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedJun 22, 2021
edited
Loading

This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release

Only when an action method doesn't end withAction nor_action, but still ends withaction, in a case-sensitive way.

I'm fine doing this on 5.4...

StaffNowa reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas changed the base branch from4.4 to5.4June 23, 2021 18:44
@nicolas-grekasnicolas-grekas modified the milestones:4.4,5.4Jun 23, 2021
@nicolas-grekas
Copy link
MemberAuthor

Now targetting 5.4

StaffNowa reacted with thumbs up emoji

@nicolas-grekas
Copy link
MemberAuthor

@Tobion comments addressed, thanks for the review!

@Tobion
Copy link
Contributor

Thank you@nicolas-grekas.

@TobionTobion merged commit83825c5 intosymfony:5.4Jul 7, 2021
@nicolas-grekasnicolas-grekas deleted the fwb-route-name branchJuly 15, 2021 08:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

Controller actions ending with words like "action" are removing the "action" part from route name

6 participants

@nicolas-grekas@ro0NL@stof@Tobion@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp