Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] fix removing "action" from route names#41782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ro0NL commentedJun 22, 2021
should we change default names in a patch release? |
stof commentedJun 22, 2021
This will break all URL generation that uses the existing names. So it might indeed be dangerous in a patch release |
ro0NL commentedJun 22, 2021
also, from my experience, dereferencing virtual route names is pure pain :D |
nicolas-grekas commentedJun 22, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Only when an action method doesn't end with I'm fine doing this on 5.4... |
nicolas-grekas commentedJun 23, 2021
Now targetting 5.4 |
...Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/AnnotatedController.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedJul 6, 2021
@Tobion comments addressed, thanks for the review! |
Tobion commentedJul 7, 2021
Thank you@nicolas-grekas. |
Uh oh!
There was an error while loading.Please reload this page.