Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunit#41780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Taluu
Copy link
Contributor

@TaluuTaluu commentedJun 22, 2021•
edited
Loading

QA
Branch?4.4 and next
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41774
LicenseMIT

Since the renaming of the simple phpunit file (from the shebang to the php file) in#31364, it looks like the change made from#36566 was lost as it seems to have been merged after.

So this PR is an attempt to "restore" that functionnality, as it was considered a bug fix on 3.4 at the time.

poke@nicolas-grekas

This change was somehow changed back during the renaming of the fileI think. So this is just restoring the change.
@TaluuTaluuforce-pushed thefix/phpunit-bridge-composer-binary-env branch from8aae62d to9589b52CompareJune 22, 2021 09:19
@Taluu
Copy link
ContributorAuthor

Note : Failures from fabbot are unrelated to the modification. Should I still apply them ?

@nicolas-grekas
Copy link
Member

Note : Failures from fabbot are unrelated to the modification. Should I still apply them ?

no need

Taluu reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas changed the titleReapply the change to use the COMPOSER_BINARY env var on simple phpunit[PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunitJun 22, 2021
@nicolas-grekas
Copy link
Member

Thank you@Taluu.

Taluu reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit8a32526 intosymfony:4.4Jun 22, 2021
@TaluuTaluu deleted the fix/phpunit-bridge-composer-binary-env branchJune 22, 2021 09:46
This was referencedJun 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Taluu@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp