Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Create a smooth upgrade path for security factories#41754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7903986 tofc667f4Comparesrc/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/RememberMeFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/JsonLoginFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fc667f4 to3a5ac34CompareStaffNowa commentedJun 27, 2021
Please make fabbot happy 😊 |
e81ff82 to5b54abcComparewouterj commentedJul 1, 2021
This is as green as this PR will get. The remaining errors are false positives. |
src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...Bundle/SecurityBundle/DependencyInjection/Security/Factory/AuthenticatorFactoryInterface.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
5b54abc to0172e56Compare...Bundle/SecurityBundle/DependencyInjection/Security/Factory/AuthenticatorFactoryInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/JsonLoginFactory.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
0172e56 to9c44ad6Comparechalasr commentedJul 14, 2021
small rebase needed |
9c44ad6 to7385fd5Comparewouterj commentedAug 7, 2021
Sorry for the delay, I forgot this one was still open. Rebased and ready :) |
chalasr commentedAug 7, 2021
Thanks Wouter. |
This change allows removing
SecurityFactoryInterfacein Symfony 6.I've also changed the discrete ordering using "listener positions" to the much more common continuous ordering using priorities. I feel like priorities are much more self-explanatory.