Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Avoid broken action URL in text notification mail#41738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mbrodala wants to merge67 commits intosymfony:5.3frommbrodala:patch-1

Conversation

@mbrodala
Copy link
Contributor

QA
Branch?5.3 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)

Fix this by moving the action text before the action URL.

nicolas-grekasand others added30 commitsMay 12, 2021 22:18
* 5.3:  Add sponsors for 5.3  Bump Symfony version to 5.3.0  Update VERSION for 5.3.0-RC1  Update CHANGELOG for 5.3.0-RC1
This PR was merged into the 5.4 branch.Discussion----------Add sponsors for 5.4| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | n/a| License       | MIT| Doc PR        | n/a/cc `@Seldaek` `@naderman`Commits-------f0c3389 Add sponsors for 5.4
* 5.3:  Add 5.3 in github PR template  Bump Symfony version to 5.2.10  Update VERSION for 5.2.9  Update CHANGELOG for 5.2.9  Bump Symfony version to 4.4.25  Update VERSION for 4.4.24  Update CONTRIBUTORS for 4.4.24  Update CHANGELOG for 4.4.24
This PR was merged into the 5.4 branch.Discussion----------Allow Symfony 6| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/ACommits-------2da144e Allow Symfony 6
* 5.3:  Remove always-true requirement
…errabus)This PR was merged into the 5.4 branch.Discussion----------Fix the detection of the stable Symfony branch| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | NA/| License       | MIT| Doc PR        | N/ACommits-------d6f4d30 Fix the detection of the stable Symfony branch
* 5.3:  Improve .travis.yml
This PR was merged into the 5.4 branch.Discussion----------[Runtime] allow "|^6.0" deps| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Commits-------20bf651 [Runtime] allow "|^6.0" deps
* 5.3:  doctrine/doctrine-bundle should not be a dep  Add missing dependency
* 5.3:  Bump symfony/http-client-implementation version
* 5.3:  [Security][SecurityBundle] Fix deprecations triggered in tests
* 5.3:  [Security] Add UserAuthenticationProviderTest to legacy group
* 5.3:  [FrameworkBundle] Return early
* 5.3:  [Ldap] Avoid calling the deprecated getUsername()  Report the correct package in the deprecation message  Wrapping exception js in Sfjs check and also loading base_js Sfjs if needed  Fix PHP 8.1 deprecations  Add missing deprecation entry  [VarDumper] Don't pass null to parse_url()  Invalid copy-paste fix
…pCache\StoreInterface` (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Add autowiring alias for `HttpCache\StoreInterface`| Q             | A| ------------- | ---| Branch?       | 5.x| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Will be useful for eg [the-fast-track](https://symfony.com/doc/current/the-fast-track/en/21-cache.html#purging-the-http-cache-for-testing) book.Commits-------3a19253 [FrameworkBundle] Add autowiring alias for `HttpCache\StoreInterface`
* 5.3:  [Messenger] Fix merging PrototypedArrayNode associative values  [Routing] Remove legacy group from Doctrine Annotations test  Add missing entry to console upgrade log  [mailer] Remove useless code
* 5.3:  Remove deprecated User from serialized test fixture
* 5.3:  Make Mailgun Header compatible with other Bridges
* 5.3:  Remove deprecation dependency
* 5.3:  [Form] fix support for years outside of the 32b range on x86 arch  CS fix  remove duplicate test  Add an upgrade note about the removal of Serializable  [SecurityBundle] Don't register deprecated listeners with authenticator manager enabled
…ce` autowiring alias, use `CacheItemPoolInterface` instead (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Deprecate the `AdapterInterface` autowiring alias, use `CacheItemPoolInterface` instead| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | -This alias is mostly noise, ppl should use the interfaces from abstract packages.Commits-------6d3e90d [FrameworkBundle] Deprecate the `AdapterInterface` autowiring alias, use `CacheItemPoolInterface` instead
* 5.3:  fix test  [HttpKernel] Throw when HttpKernel is created and the env is empty
nicolas-grekasand others added14 commitsJune 8, 2021 11:12
* 5.3:  sync logic to determine the default value
* 5.3:  [DependencyInjection] Removed unsetting of environment property in loaders  [Messenger] fix BC for FrameworkBundle 4.4 with a non-existence alias being used  fix tests  Optimize travis file a bit  [DependencyInjection] Fix testServiceSubscriber for PHP 8.1  Remove duplicate catch block  Add missing translations for Thai  Add missing translations for Swedish  [Serializer] Fix not null return check by "getCollectionKeyTypes"
* 5.3:  [HttpClient] Revert bindto workaround
* 5.3:  [Config] Backport type declarations  [VarExporter] Fix test on PHP 8.1  [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1
* 5.3:  [PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type in signatures  [HttpClient] throw exception when AsyncDecoratorTrait gets an already consumed response  [Notifier] Escape `.` char for Telegram transport  [Validator] Fix tests by making constraint options dumps order consistent
* 5.3:  [PasswordHasher] Remove PasswordHasherAwareInterface from UserPasswordHasherInterface API
…LIDs (fancyweb)This PR was merged into the 5.4 branch.Discussion----------[VarDumper] Add casters for Symfony UUIDs and ULIDs| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Before:![Screenshot from 2021-06-04 10-29-30](https://user-images.githubusercontent.com/3658119/120772362-87a07f80-c520-11eb-9430-3bdda6ed164b.png)After:![Screenshot from 2021-06-11 14-18-48](https://user-images.githubusercontent.com/3658119/121685253-fef58680-cabf-11eb-9c86-add575fee97e.png)Commits-------0dde2cc [VarDumper] Add casters for Symfony UUIDs and ULIDs
* 5.3:  [Console] Fix using #[AsCommand] without DI  [DependencyInjection] fix parsing classes for attributes  [HttpClient] fix compat with cURL <= 7.37  [Console] fix managing signals when commands are lazy loaded  Remove Debug component from patch-types.php  [Uid] Realign inspect commands labels  [Runtime] fix overriding --env|-e with single-command apps  [Serializer] Fix call to expectExceptionMessage()  [Config] fix tracking attributes in ReflectionClassResource  [Process] Fix incorrect parameter type  [HttpFoundation] Handle tentative return types
* 5.3:  Minor typo in PHPDoc comment
* 5.3:  [FrameworkBundle] fix leftover  [Uid] fix performance and prevent collisions with the real clock_seq  Fix RequestContext not updated  bugsymfony#41715: [FrameworkBundle] Partial backport of PR#41530  [Security] Restore extension point in MessageDigestPasswordEncoder  Fix some typos in Greek language  [Security] Fix deprecation notice on TokenInterface::getUser() stringable return  Remove TLS related options when not using TLS
* 5.3:  Only trigger for the correct firewall in ContextListener::onKernelResponse()
* 5.3:  Bump Symfony version to 5.3.3  Update VERSION for 5.3.2  Update CHANGELOG for 5.3.2
Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)Fix this by moving the action text before the action URL.
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@mbrodala
Copy link
ContributorAuthor

Wrong base (5.4) against target (5.3), thus replaced by#41739

@mbrodalambrodala deleted the patch-1 branchJune 18, 2021 07:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

9 participants

@mbrodala@carsonbot@nicolas-grekas@fabpot@derrabus@xabbuh@jderusse@fancyweb@chalasr

[8]ページ先頭

©2009-2025 Movatter.jp