When launching phpunit, got an error:
LogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true".

There was 1 error:1) App\Symfony\Bundle\Tests\Integration\IntegrationTest::testServiceWiringWithConfigurationLogicException: Could not find service "test.service_container". Try updating the "framework.test" config to "true"./Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:109/Projects/app/tests/integration/IntegrationTest.php:23Caused bySymfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "test.service_container". Did you mean this: "service_container"?/Projects/app/vendor/symfony/dependency-injection/Container.php:280/Projects/app/vendor/symfony/dependency-injection/Container.php:228/Projects/app/vendor/symfony/framework-bundle/Test/KernelTestCase.php:107/Projects/app/tests/integration/IntegrationTest.php:23

/cc@xabbuh @nicolas-grekas

bugsymfony#41715: [FrameworkBundle] Partial backport of PR#41530

0748b52

symfony#41715symfony#41530

carsonbot added Status: Needs Review Bug FrameworkBundle labels

Jun 15, 2021

carsonbot added this to the5.2 milestone

Jun 15, 2021

Copy link

carsonbot commentedJun 15, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

carsonbot changed the title~~bug #41715: [FrameworkBundle] Partial backport of PR#41530~~[FrameworkBundle] bug #41715: Partial backport of PR#41530

Jun 15, 2021

Copy link

Contributor

YaFou commentedJun 16, 2021

Can you implement a test please?

Copy link

ContributorAuthor

smilesrg commentedJun 16, 2021

Can you implement a test please?

Well... this is a backport of PR that hasn't any tests... Probably I can, but I'm not sure how to test these changes properly.

nicolas-grekas changed the title~~[FrameworkBundle] bug #41715: Partial backport of PR#41530~~[FrameworkBundle] fix Could not find service "test.service_container"

Jun 17, 2021