Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix RequestContext not updated#41716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3fromjderusse:messenger-reqcontext
Jun 17, 2021

Conversation

@jderusse
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

TheRouterContextMiddleware updates the context of the injectedRequestContextAwareInterface but this is wrong, the context object could have been injected in many services (ie. Router, UrlHelper).
CallingsetContext updates the context for one services, but all other services are still using the old one.

This PR uses the injectedRequestContextAwareInterface to fetch the currentContext and then changes its properties.

@jderussejderusse requested a review fromsroze as acode ownerJune 15, 2021 14:05
@carsonbotcarsonbot added this to the5.3 milestoneJun 15, 2021
@carsonbotcarsonbot changed the title[messenger] Fix RequestContext not updated[Messenger] Fix RequestContext not updatedJun 15, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have a better idea :(
router.request_context is another stateful service we need to ditch!
finding a way to removeRequestContextAwareInterface would be great also...

ro0NL reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commitf8222f7 intosymfony:5.3Jun 17, 2021
@fabpotfabpot mentioned this pull requestJun 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@jderusse@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp