Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] Fix tests for PHP 8.1#41701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alexandre-daubois commentedJun 14, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Part of#41552 |
| License | MIT |
| Doc PR | N/A |
9f41eb0 to5db7f8bComparesrc/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
derrabus commentedJun 15, 2021
Can you explain why the dumper behaves differently on PHP 8.1? |
stof commentedJun 15, 2021
@derrabus looks like the behavior of |
alexandre-daubois commentedJun 15, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@derrabus also, some other functions seem to have changed their behaviour. For example, when |
5db7f8b to44efb72Comparederrabus commentedJun 16, 2021
I'd like to clarify first, if that change was intentional:https://bugs.php.net/bug.php?id=81147 |
derrabus commentedJun 16, 2021
The other changes look reasonable to me. |
derrabus commentedJun 16, 2021
Okay, that was fast and we've got the answer we were looking for.
Can you have a look at the Travis failure? It looks related. |
alexandre-daubois commentedJun 16, 2021
Thank you so much for your investigation, super good to know! I'll definitely take a look at Travis tomorrow to finish this PR. 👍 |
44efb72 to9c00d21Compare9c00d21 tof2b0822Comparealexandre-daubois commentedJun 17, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@derrabus done 👌This failing build for 7.4 seems unrelated to this PR. I'm not sure I understand the difference between "Tests / Integration (x.x)" and Travis CI tests ? |
derrabus commentedJun 22, 2021
Thank you@alexandre-daubois. |