Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Fix deprecation notice on TokenInterface::getUser() stringable return#41700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3fromtscni:patch-security-deprecation
Jun 17, 2021
Merged

[Security] Fix deprecation notice on TokenInterface::getUser() stringable return#41700

nicolas-grekas merged 1 commit intosymfony:5.3fromtscni:patch-security-deprecation
Jun 17, 2021

Conversation

@tscni
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

AuthenticatorManager raises a deprecation notice about the missing implementation ofUserInterface::getUserIdentifier() whenTokenInterface::getUser() returns a string.
This fixes that issue.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

…able returnAuthenticatorManager raises a deprecation notice about the missing implementation of UserInterface::getUserIdentifier() when TokenInterface::getUser() returns a string.This fixes that issue.
@nicolas-grekas
Copy link
Member

Thank you@tscni.

@nicolas-grekasnicolas-grekas merged commit66f7b7a intosymfony:5.3Jun 17, 2021
@tscnitscni deleted the patch-security-deprecation branchJune 17, 2021 13:01
@fabpotfabpot mentioned this pull requestJun 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@tscni@carsonbot@nicolas-grekas@stof@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp