Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Uid] fix performance and prevent collisions with the real clock_seq#41693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3fromnicolas-grekas:uid-perf
Jun 17, 2021

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.3
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Spotted while preparingmy talk.

fancyweb reacted with rocket emoji
@fancyweb
Copy link
Contributor

Do you have numbers to share? 😁

@nicolas-grekas
Copy link
MemberAuthor

Yes, you need to see my talk :P

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What a way to promote your talk.

derrabus, nicolas-grekas, and shyim reacted with laugh emoji
@nicolas-grekasnicolas-grekasforce-pushed theuid-perf branch 3 times, most recently from57e7a1f tobf75bd2CompareJune 14, 2021 15:14
@nicolas-grekasnicolas-grekas changed the title[Uid] fix performance[Uid] fix performance and prevent collisions with the real clock_seqJun 14, 2021
Copy link
MemberAuthor

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now with another bugfix: when a time is passed to generate a V1 or V6 UUID, the clock_seq is borrowed from the node if one is also set, or a static one is randomly generated otherwise.
This prevents any potential collisions with the real current clock seq.

@derrabus
Copy link
Member

For my understanding: The fix is that you prevent validating the same UUID/ULID twice when initializing them withfromString(), correct?

@nicolas-grekas
Copy link
MemberAuthor

Absolutely!

derrabus reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit9fb0fc9 intosymfony:5.3Jun 17, 2021
@fabpotfabpot mentioned this pull requestJun 17, 2021
nicolas-grekas added a commit that referenced this pull requestJun 23, 2021
…th base32 values (fancyweb)This PR was merged into the 5.3 branch.Discussion----------[Uid] Prevent double validation in Uuid::fromString() with base32 values| Q             | A| ------------- | ---| Branch?       | 5.3| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Follow up to#41693, it should be a little bit faster if we don't validate twice, right?Commits-------043ee56 [Uid] Prevent double validation in Uuid::fromString() with base32 values
@nicolas-grekasnicolas-grekas deleted the uid-perf branchJune 24, 2021 08:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@NyholmNyholmNyholm approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@fancyweb@derrabus@Nyholm@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp