Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Table vertical rendering#41676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedJun 11, 2021
Having 2 booleans named |
yoannrenard commentedJun 11, 2021
I agree with you@stof |
15e9ab8 toa37528eCompareUh oh!
There was an error while loading.Please reload this page.
d4a17b9 to69b28e8CompareUh oh!
There was an error while loading.Please reload this page.
94noni left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would love to have it in v5.4 :)
69b28e8 to1221afeCompare
GromNaN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a cool feature. Can you rebase it on 6.1 and adapt the syntax with PHP 8.1 capabilities?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
1221afe to1ed9549Compareyoannrenard commentedMar 20, 2022
Thanks for your review@GromNaN |
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice feature! Thanks Yoann.
chalasr commentedApr 26, 2022
@yoannrenard Can you please rebase again on 6.1? |
Uh oh!
There was an error while loading.Please reload this page.
1ed9549 todefd326CompareUh oh!
There was an error while loading.Please reload this page.
Using an enum instead of 2 separated booleansRephrase changelog for better consistency
defd326 to15fa4c5CompareGromNaN commentedMay 9, 2022
Thank you@yoannrenard. |
yoannrenard commentedMay 10, 2022
You are welcome@GromNaN |
…ering (nicolas-grekas)This PR was merged into the 6.1 branch.Discussion----------[Console] fix CS for code related to Table vertical rendering| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -A quick review of#41676 made me submit this.Commits-------41ff71e [Console] fix CS for code related to Table vertical rendering
Uh oh!
There was an error while loading.Please reload this page.
This PR adds a way to render Console Tables vertically. This is inspired by the way MySQL and PostgreSQL do with the '\G' command terminator.
For example, if we use this vertical rendering for the command
debug:validator, the command would show something like:Instead of :
Which is hard to read.