Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Remove deprecation layer#41657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Serializer] Remove deprecation layer#41657
Uh oh!
There was an error while loading.Please reload this page.
Conversation
derrabus commentedJun 10, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
b608c8e to40042a6Comparecarsonbot commentedJun 11, 2021
Hey! I think@xfifix has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
40042a6 tof6a01e8Comparef6a01e8 to222ea81Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please rebase so that we can see green tests :)
Uh oh!
There was an error while loading.Please reload this page.
222ea81 to42061beComparederrabus commentedJun 30, 2021
Fabbot failure is the usual false positive, AppVeyor failure is unrelated. The remaining tests are green. |
| } | ||
| } | ||
| publicfunction__construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be on one line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
when using constructor property promotion, I think we should use several lines actually
we do so already for attributes
| thrownew \TypeError(sprintf('"%s": Argument $typeProperty was expected to be a string or array, got "%s".',__METHOD__,get_debug_type($typeProperty))); | ||
| } | ||
| publicfunction__construct( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same here
Signed-off-by: Alexander M. Turek <me@derrabus.de>
42061be to56034b5Comparenicolas-grekas commentedJul 3, 2021
Thank you@derrabus. |