Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PasswordHasher] Add union types#41640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ValentineBoineau
Copy link
Contributor

QA
Branch?6.0
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Extracted from#41424

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@ValentineBoineauValentineBoineauforce-pushed theunion-types-passwordhasher branch 2 times, most recently from01da7b0 tofe3fdfdCompareJune 9, 2021 13:55
@carsonbotcarsonbot changed the title[PasswordHasher] Add union typesAdd union typesJun 9, 2021
@ValentineBoineauValentineBoineau marked this pull request as ready for reviewJune 9, 2021 14:04
@carsonbotcarsonbot added this to the6.0 milestoneJun 9, 2021
@ValentineBoineauValentineBoineauforce-pushed theunion-types-passwordhasher branch fromfe3fdfd to5005cdfCompareJune 9, 2021 14:28
@carsonbotcarsonbot changed the titleAdd union types[PasswordHasher] Add union typesJun 9, 2021
@ValentineBoineauValentineBoineauforce-pushed theunion-types-passwordhasher branch 2 times, most recently from9df0ac9 to2af3710CompareJune 10, 2021 17:05
@chalasrchalasrforce-pushed theunion-types-passwordhasher branch 2 times, most recently fromb47497f toe0a3ad3CompareJune 10, 2021 17:42
@ValentineBoineauValentineBoineauforce-pushed theunion-types-passwordhasher branch 8 times, most recently fromf99c3be to501b827CompareJune 11, 2021 09:29
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With some nitpicking.
@chalasr shouldn't we backport some changes to 5.3?

chalasr added a commit that referenced this pull requestJun 11, 2021
…allowed type (chalasr)This PR was merged into the 5.3 branch.Discussion----------[PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type| Q             | A| ------------- | ---| Branch?       | 5.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License | MIT| Doc PR | -Also backports test changes from#41640Commits-------8d3bea5 [PasswordHasher] Fix missing PasswordHasherAwareInterface allowed type in signatures
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Rebase needed after#41678

chalasr added a commit that referenced this pull requestJun 11, 2021
…e from UserPasswordHasherInterface API (chalasr)This PR was merged into the 5.3 branch.Discussion----------[PasswordHasher] Remove PasswordHasherAwareInterface type from UserPasswordHasherInterface API| Q             | A| ------------- | ---| Branch?       | 5.3| Bug fix?      | no (not yet released)| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -As spotted by `@stof` in#41640 (comment), the methods of this interface should not handle user classes/instances that are not implementing `PasswordAuthenticatedUserInterface`.This reverts that part from#41678 (not released yet).Commits-------596ba78 [PasswordHasher] Remove PasswordHasherAwareInterface from UserPasswordHasherInterface API
@chalasrchalasrforce-pushed theunion-types-passwordhasher branch fromb57bce2 to8628479CompareJune 11, 2021 16:50
@chalasr
Copy link
Member

Thank you@ValentineBoineau.

@chalasrchalasr merged commite5bbf62 intosymfony:6.0Jun 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ValentineBoineau@carsonbot@chalasr@nicolas-grekas@stof
[8]ページ先頭
©2009-2025 Movatter.jp