Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Config] Backport type declarations#41630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:4.4fromderrabus:types/config-backports
Jun 9, 2021

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

This PR backports type declarations from#41575 where it's safe to do so.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I personally skip tests in such PRs because that provides nothing but a waste of my time when merging up. If you're willing to do the merge up, I'm fine :P

@derrabus
Copy link
MemberAuthor

All the tests I've touched here still exist on 6.0, mostly unmodified. I'll happily do the merge. 🙂

@derrabusderrabus merged commit510be7a intosymfony:4.4Jun 9, 2021
@derrabusderrabus deleted the types/config-backports branchNovember 21, 2021 12:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp