Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Remove everything related to the deprecated authentication manager#41613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

wouterj
Copy link
Member

@wouterjwouterj commentedJun 8, 2021•
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

This PR removes all deprecations from the security packages.

Some previously deprecated methods are now marked as@internal (e.g.loadUserByUsername() in the LDAP user provider) in order to remain compatible with Symfony 5.4.

chalasr, lyrixx, nicolas-grekas, aschempp, Toflar, and bytehead reacted with hooray emojifritzmg and creo-code reacted with rocket emoji
@wouterjwouterj added this to the6.0 milestoneJun 8, 2021
@wouterjwouterj requested a review fromchalasr as acode ownerJune 8, 2021 11:02
@carsonbotcarsonbot changed the title[WIP][Security] Remove everything related to the deprecated authentication manager[Security] [WIP] Remove everything related to the deprecated authentication managerJun 8, 2021
@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch fromdb6d1bc to133675bCompareJune 8, 2021 11:18
@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch from133675b toea1395bCompareJune 8, 2021 12:28
@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch fromea1395b toc5d60fbCompareJune 8, 2021 12:30
Copy link
Member

@chalasrchalasr left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉🎉🎉 Thanks Wouter!

Some minor comments below.
Let's split and share the deprecation work that needs to be done for 5.4 before merging this one.
Some minor comments

fabpot added a commit that referenced this pull requestJul 8, 2021
…ion on no token" (wouterj)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate "always authenticate" and "exception on no token"| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | Ref#41613| License       | MIT| Doc PR        | n/aCommits-------4bba287 [Security] Deprecate "always authenticate" and "exception on no token"
derrabus added a commit that referenced this pull requestJul 14, 2021
…)` (chalasr)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate `TokenInterface::isAuthenticated()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | todoFrom#41613 (comment)> all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated.Commits-------33b8fbd [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
symfony-splitter pushed a commit to symfony/security-guard that referenced this pull requestJul 14, 2021
…)` (chalasr)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate `TokenInterface::isAuthenticated()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | todoFromsymfony/symfony#41613 (comment)> all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated.Commits-------33b8fbdd8a [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestJul 14, 2021
…)` (chalasr)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate `TokenInterface::isAuthenticated()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | todoFromsymfony/symfony#41613 (comment)> all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated.Commits-------33b8fbdd8a [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
symfony-splitter pushed a commit to symfony/monolog-bridge that referenced this pull requestJul 14, 2021
…)` (chalasr)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate `TokenInterface::isAuthenticated()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | todoFromsymfony/symfony#41613 (comment)> all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated.Commits-------33b8fbdd8a [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
symfony-splitter pushed a commit to symfony/security-http that referenced this pull requestJul 14, 2021
…)` (chalasr)This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate `TokenInterface::isAuthenticated()`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | todoFromsymfony/symfony#41613 (comment)> all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated.Commits-------33b8fbdd8a [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
chalasr added a commit that referenced this pull requestAug 7, 2021
…rity factories (wouterj)This PR was merged into the 5.4 branch.Discussion----------[SecurityBundle] Create a smooth upgrade path for security factories| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| Tickets       | Ref#41613 (comment)| License       | MIT| Doc PR        | -This change allows removing `SecurityFactoryInterface` in Symfony 6.I've also changed the discrete ordering using "listener positions" to the much more common continuous ordering using priorities. I feel like priorities are much more self-explanatory.Commits-------7385fd5 [SecurityBundle] Create a smooth upgrade path for security factories
fabpot added a commit that referenced this pull requestAug 8, 2021
This PR was merged into the 5.4 branch.Discussion----------[Security] Deprecate legacy signatures| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | Ref#41613| License       | MIT| Doc PR        | n/aDeprecates the left-over legacy constructor signatures in the Security system.Commits-------bbc00c8 [Security] Deprecate legacy signatures
@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch fromc5d60fb to199c99cCompareAugust 12, 2021 10:31
@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch 2 times, most recently from1c241ff to37ea08fCompareAugust 17, 2021 16:38
@wouterjwouterj changed the title[Security] [WIP] Remove everything related to the deprecated authentication manager[Security] Remove everything related to the deprecated authentication managerAug 17, 2021
@wouterj
Copy link
MemberAuthor

wouterj commentedAug 17, 2021•
edited
Loading

🟢 !

The remaining deps=high failures are unrelated to changes in this PR. Also updated the PR description, this is no longer a todo list :)
Happy reviewing! 😉

@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch 3 times, most recently from026a480 toc242a87CompareAugust 18, 2021 09:33
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Only minor things on my side after a quick review.
Thank you so much for working on this!

@wouterjwouterjforce-pushed thesecurity/remove-authenticator-deprecations branch 2 times, most recently from4934d38 to24ad008CompareAugust 18, 2021 12:49
@nicolas-grekasnicolas-grekasforce-pushed thesecurity/remove-authenticator-deprecations branch from24ad008 to922c131CompareAugust 18, 2021 13:00
@nicolas-grekas
Copy link
Member

Thank you@wouterj.

@nicolas-grekasnicolas-grekas merged commit61cf95e intosymfony:6.0Aug 18, 2021
@wouterjwouterj deleted the security/remove-authenticator-deprecations branchAugust 18, 2021 13:20
@wouterj
Copy link
MemberAuthor

🎉 thank you for eviewing and merging!

lyrixx reacted with hooray emoji

@fabpotfabpot mentioned this pull requestNov 5, 2021
Tobion added a commit that referenced this pull requestApr 20, 2022
This PR was merged into the 6.0 branch.Discussion----------[SecurityBundle] Remove forgotten unused code| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Forgotten in#41613Commits-------9d35f00 [SecurityBundle] Remove forgotten unused code
nicolas-grekas added a commit that referenced this pull requestJun 28, 2024
…ute from the XSD (MatTheCat)This PR was merged into the 6.4 branch.Discussion----------[SecurityBundle] Remove unused memory users’ `name` attribute from the XSD| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | N/A| License       | MITThe related config has been deprecated in#40403 and removed in#41613.Commits-------656f498 [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD
nicolas-grekas added a commit that referenced this pull requestJun 28, 2024
…ibute from the XSD (MatTheCat)This PR was merged into the 6.4 branch.Discussion----------[SecurityBundle] Remove unused memory users’ `name` attribute from the XSD| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | Fixcdb8354| License       | MIT#57520 has been reverted because> [The] change […] risks that someone receives errors on the next patch release if their XML config still makes use of the now removed attribute.But nobody could use it since v6.0: as#41613 removed the BC layer, the config would crash.Keeping `name` in the XSD for 6.4, 7.0 and 7.1 branches means people using these versions would have their IDE suggesting an attribute which would make their app crash.Commits-------ed5c26c [SecurityBundle] Remove unused memory users’ `name` attribute from the XSD
nicolas-grekas added a commit that referenced this pull requestJun 2, 2025
…tTheCat)This PR was merged into the 6.4 branch.Discussion----------[SecurityBundle] Remove `AnonymousFactory` leftovers| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | N/A| License       | MITThe `AnonymousFactory` was removed in#41613 but the related configuration was still referenced in the `SecurityExtension`.(Not sure about the target branch since this isn’t a bugfix.)Commits-------0bd8eb2 [SecurityBundle] Remove `AnonymousFactory` leftovers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@sstoksstoksstok left review comments

@chalasrchalasrchalasr left review comments

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

6 participants
@wouterj@fabpot@nicolas-grekas@sstok@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp