This PR enables users to use thewhen@{environment} in imported files. I found that the env was explicitly unset when loading the file (including its imports) which resulted in the environment not being set when processing the imports.

Seehttps://github.com/nusje2000/symfony-41584-reproducer for a reproduction of the problem.

carsonbot added Status: Needs Review Bug labels

Jun 7, 2021

Copy link

carsonbot commentedJun 7, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas added this to the5.3 milestone

Jun 8, 2021

[DependencyInjection] Removed unsetting of environment property in lo…

18fe0dd

…aders

nicolas-grekas changed the title~~[Dependency Injection] Removed unsetting of environment property in loaders~~[DependencyInjection] fixwhen@{env} inside imported files

Jun 8, 2021

nicolas-grekas changed the base branch from5.4 to5.3

June 8, 2021 15:09

nicolas-grekas force-pushed thefeature/support-single-file-environment-config-in-imports branch fromc306b4f to18fe0ddCompare

June 8, 2021 15:09