Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Add Union Types#41587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ValentineBoineau
Copy link
Contributor

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

Extracted from#41424

@carsonbotcarsonbot changed the title[Cache]Add Union TypeAdd Union TypeJun 7, 2021
@ValentineBoineauValentineBoineau changed the titleAdd Union TypeAdd Union TypesJun 7, 2021
@ValentineBoineauValentineBoineau changed the titleAdd Union Types[Cache] Add Union TypesJun 7, 2021
@ValentineBoineauValentineBoineauforce-pushed theadd-union-type-doctrineprovider branch 12 times, most recently fromcf03cc2 toc8eaa9eCompareJune 8, 2021 12:28
@nicolas-grekasnicolas-grekas added this to the6.0 milestoneJun 8, 2021
@ValentineBoineauValentineBoineauforce-pushed theadd-union-type-doctrineprovider branch 4 times, most recently from53c2842 to8d70d80CompareJune 8, 2021 14:28
@ValentineBoineauValentineBoineauforce-pushed theadd-union-type-doctrineprovider branch from8d70d80 tod60d227CompareJune 8, 2021 15:22
@nicolas-grekas
Copy link
Member

This PR collides with#41290 from@derrabus, I fear we might prefer closing it in favor of#41290, since return types must be added at the same time as arguments because of the PSR dependency...

@derrabus
Copy link
Member

We can finish this PR first and I'll happily rebase mine afterwards.

@nicolas-grekas
Copy link
Member

Can we? Because we support psr/cache v1, we cannot update argument types...

@derrabus
Copy link
Member

#41290 was about adding return types. For now, I'd skip the argument types coming from PSR Cache because that is a bit more complicated. For instance, the integration test suite we're using does not handle them well yet.

So, let's make this PR about adding parameter types to all methods except the psr/cache implementations and iterate further afterwards.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ValentineBoineau@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp