Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix not null get collection key types#41582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dragosprotung
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Warning: Undefined array key 0 is generated becausegetCollectionKeyTypes never returnsnull so a check against empty array is needed.

@carsonbotcarsonbot added this to the5.3 milestoneJun 7, 2021
@dragosprotungdragosprotung changed the titleFix not null get collection key types[Serializer] Fix not null get collection key typesJun 7, 2021
Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was missed in#41463? LGTM

Could you add a test, though?

@carsonbotcarsonbot changed the title[Serializer] Fix not null get collection key typesFix not null get collection key typesJun 7, 2021
@dragosprotung
Copy link
ContributorAuthor

I would add a test if I could even begin to know how to write a test for it. It's too deep into a private method and do not really know how to set it up

@nicolas-grekas
Copy link
Member

Maybe you can take inspiration from the tests added to#41463?

@dragosprotung
Copy link
ContributorAuthor

In#41463 there was no test added for theSerializer component after the fixes. The test was added forValidator, related to the changes made inSymfony\Component\Validator\Mapping\Loader\PropertyInfoLoader

@nicolas-grekas
Copy link
Member

Thank you@dragosprotung.

@nicolas-grekasnicolas-grekas merged commit22fd960 intosymfony:5.3Jun 8, 2021
@dragosprotungdragosprotung deleted the fix/not-null-getCollectionKeyTypes branchJune 8, 2021 14:42
@fabpotfabpot mentioned this pull requestJun 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@dragosprotung@nicolas-grekas@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp