Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config] Add parameter types#41575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.0fromderrabus:types/config
Jun 29, 2021
Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedJun 6, 2021•
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
TicketsPart of#41424
LicenseMIT
Doc PRN/A

This PR adds parameter types to all methods of the Config component.

* @param bool|string $ignoreErrors Whether errors should be ignored; pass "not_found" to ignore only when the loaded resource is not found
*/
publicfunctionimport($resource,string$type =null,$ignoreErrors =false,string$sourceResource =null,$exclude =null)
publicfunctionimport(mixed$resource,string$type =null,bool |string$ignoreErrors =false,string$sourceResource =null,$exclude =null)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've omitted the type declaration for$exclude in order to maintain compatibility with Config 5.4. Shall I keep it that way or shall I bump?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's keep compat

@carsonbot
Copy link

Hey!

I think@jschaedl has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

derrabus added a commit that referenced this pull requestJun 9, 2021
This PR was merged into the 4.4 branch.Discussion----------[Config] Backport type declarations| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AThis PR backports type declarations from#41575 where it's safe to do so.Commits-------46e18af [Config] Backport type declarations
@derrabusderrabusforce-pushed thetypes/config branch 2 times, most recently from5aa99b3 toa9e75c2CompareJune 9, 2021 11:16
@derrabusderrabusforce-pushed thetypes/config branch 2 times, most recently from9fada46 to4754580CompareJune 29, 2021 09:43
@derrabusderrabusforce-pushed thetypes/config branch 4 times, most recently from35eec33 to7ec2142CompareJune 29, 2021 10:31
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit76ee4a5 intosymfony:6.0Jun 29, 2021
@derrabusderrabus deleted the types/config branchJune 29, 2021 11:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp