Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PasswordHasher] Prevent PHP fatal error when using auto algorithm#41572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@matason
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41571
LicenseMIT
Doc PRN/A

Fixes a PHP fatal error that occurs when using the auto algorithm of the PasswordHasher in a standalone project.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabusderrabus added this to the5.3 milestoneJun 6, 2021
@derrabus
Copy link
Member

Can you please rebase your patch onto 5.3?

matason reacted with thumbs up emoji

@matasonmatason changed the base branch from5.4 to5.3June 6, 2021 19:35
@matasonmatason changed the title[PasswordHasher] Prevent PHP warning when using auto algorithmWIP:[PasswordHasher] Prevent PHP warning when using auto algorithmJun 6, 2021
@matasonmatasonforce-pushed thepassword-hasher-prevent-warning branch from7d8ab05 toeb35b21CompareJune 6, 2021 19:40
@matasonmatason changed the titleWIP:[PasswordHasher] Prevent PHP warning when using auto algorithm[PasswordHasher] Prevent PHP warning when using auto algorithmJun 6, 2021
@matason
Copy link
ContributorAuthor

Can you please rebase your patch onto 5.3?

Doh, of course, that's done now, sorry about that!

derrabus reacted with thumbs up emoji

@derrabus
Copy link
Member

No worries. 🙂 And can you please apply the code style patch from fabbot?

matason reacted with thumbs up emoji

@derrabus
Copy link
Member

Your change looks correct, but would you be able to add a small test case? I'd like to make sure we don't break your use-case again in the future.

@matason
Copy link
ContributorAuthor

matason commentedJun 6, 2021 via email•
edited
Loading

Sure, I’ll do that tomorrow!

@matasonmatasonforce-pushed thepassword-hasher-prevent-warning branch from19df534 todca28a2CompareJune 7, 2021 07:13
@matasonmatason changed the title[PasswordHasher] Prevent PHP warning when using auto algorithm[PasswordHasher] Prevent PHP fatal error when using auto algorithmJun 7, 2021
@chalasr
Copy link
Member

PasswordHasher in a standalone project

Nice!

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks for reporting and fixing this bug.

matason and derrabus reacted with heart emoji
@derrabus
Copy link
Member

Good catch, thanks@matason.

@derrabusderrabus merged commit91585e4 intosymfony:5.3Jun 7, 2021
@fabpotfabpot mentioned this pull requestJun 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

[PasswordHasher] Generates a PHP fatal error when using auto algorithm

4 participants

@matason@carsonbot@derrabus@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp