Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Introduced new method for getting bundles config path#41566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4froma-menshchikov:bundles_path
Sep 8, 2021

Conversation

@a-menshchikov
Copy link
Contributor

@a-menshchikova-menshchikov commentedJun 6, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#15423

At the moment bundles path duplicated in MicroKernelTrait: inregisterBundles andregisterContainerConfiguration methods. This leads to need to override the both methods if bundles config stored by custom path (e.g. when multiple kernels used).

The new method allows override the only itself when custom path is used.

mynameisbogdan reacted with thumbs up emoji
@a-menshchikov
Copy link
ContributorAuthor

@nicolas-grekas are there some other problems that should be fixed?

@a-menshchikova-menshchikov requested a review fromstofJune 30, 2021 09:42
@fabpot
Copy link
Member

Thank you@a-menshchikov.

@fabpotfabpot merged commit7c531f5 intosymfony:5.4Sep 8, 2021
@a-menshchikova-menshchikov deleted the bundles_path branchSeptember 8, 2021 08:20
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestSep 23, 2021
…sPath with Multiple Kernels (a-menshchikov)This PR was merged into the 5.4 branch.Discussion----------[Configuration] Using MicroKernelTrait::getBundlesPath with Multiple KernelsSeesymfony/symfony#41566Commits-------a69f6b3 MicroKernelTrait::getBundlesPath
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@a-menshchikov@fabpot@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp