Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Fix negated options not accessible#41535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:5.3fromjderusse:fix-negate
Jun 4, 2021

Conversation

@jderusse
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41531
LicenseMIT
Doc PR-

Removing the--no-ansi option to only let the negatable option--ansi breaks applications that expects calling$input->getOption('no-ansi')

This PR provides a fallback to return the negative value of the negatable options

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me 👍 Thanks

@chalasr
Copy link
Member

Thank you Jérémy.

@dereuromark
Copy link

I see a release for symfony/symfony 5.3.1 that seems to include the fix, buthttps://packagist.org/packages/symfony/console shows no such split package for console.
We do need it to resolve our BC breaking issues, though. Is that stilled planned or did the release go wrong?
Thank you.

@jderussejderusse deleted the fix-negate branchJune 8, 2021 09:24
@fabpotfabpot mentioned this pull requestJun 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

5 participants

@jderusse@chalasr@dereuromark@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp