Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Ldap] Fixing the behaviour of getting LDAP Attributes#41527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJun 3, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedJun 3, 2021
Shouldn't this PR target a lower branch, eg 4.4? |
mr-sven commentedJun 3, 2021
Here the snippents from my config. Without the modification the memberOf will fail. It took me half a day of researching because the documentation is missing the service tag for the ldap service. # /config/packages/security.yamlsecurity:enable_authenticator_manager:trueproviders:provider_ldap:ldap:service:Symfony\Component\Ldap\Ldapbase_dn:dc=planetexpress,dc=comsearch_dn:cn=admin,dc=planetexpress,dc=comsearch_password:GoodNewsEveryonedefault_roles:ROLE_USERuid_key:uidextra_fields:['givenName','sn','mail','memberOf']firewalls:dev:pattern:^/(_(profiler|wdt)|css|images|js)/security:falsemain:lazy:trueform_login_ldap:service:Symfony\Component\Ldap\Ldapenable_csrf:truelogin_path:logincheck_path:logindn_string:dc=planetexpress,dc=comquery_string:'(&(uid={username}))'search_dn:cn=admin,dc=planetexpress,dc=comsearch_password:GoodNewsEveryonelogout:path:logoutaccess_control: -{ path: ^/login, roles: IS_ANONYMOUS } -{ path: ^/, roles: ROLE_USER } # /config/services.yamlservices:Symfony\Component\Ldap\Ldap:arguments:['@Symfony\Component\Ldap\Adapter\ExtLdap\Adapter']# the documentation is missing the service tagtags:['ldap']Symfony\Component\Ldap\Adapter\ExtLdap\Adapter:arguments: -host:localhostport:10386#encryption: tlsoptions:protocol_version:3referrals:false |
OskarStark commentedJun 5, 2021
This should target 🎯 4.4 and can you please add a testcase to avoid further regression? |
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM as a new feature.
fabpot commentedAug 26, 2021
Thank you@mr-sven. |
Uh oh!
There was an error while loading.Please reload this page.
Some of the attributes in LDAP are not shipped via
filter = *, they have to be requested. Example thememberOfattribute using the OpenLDAP docker demorroemhild/docker-test-openldap. ThememberOfattribute is an overlay and only available on request.ldapsearch example without requesting
memberOf:ldapsearch example with requesting
memberOf: