Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Link UserProviderListener to correct firewall dispatcher#41509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Matth--
Copy link
Contributor

@Matth--Matth-- commentedJun 2, 2021•
edited
Loading

QA
Branch?5.2
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#40158 ,Fix#41474
LicenseMIT
Doc PR/

When using the new AuthenticationManager, an incorrect UserProvider could be attached to the UserBadge when having multiple providers defined insecurity.yaml.

TheUserProviderListener was tagged to the global event dispatcher instead of the dispatcher for the specific firewall.

michaelKaefer reacted with thumbs up emoji
@Matth--Matth-- changed the base branch from5.4 to5.2June 2, 2021 09:33
@carsonbotcarsonbot added this to the5.2 milestoneJun 2, 2021
@nicolas-grekas
Copy link
Member

Can you please add a test case if possible?

@Matth--Matth--force-pushed thefix/user-provider-listener branch 2 times, most recently from79d3ab1 tod65695dCompareJune 2, 2021 11:29
@Matth--
Copy link
ContributorAuthor

Matth-- commentedJun 2, 2021•
edited
Loading

@nicolas-grekas I added some functional tests (Feel like this was the better way to get failing tests first).
The tests were failing without the change to theSecurityExtension class.

Do you have a suggestion to fix the Travis ci bugs? I feel like it used the Symfony 5.4 branch to run tests against.

@Matth--Matth--force-pushed thefix/user-provider-listener branch fromd65695d to0a713f2CompareJune 2, 2021 12:33
@derrabus
Copy link
Member

Do you have a suggestion to fix the Travis ci bugs?

I'd say, the Travis failure is unrelated to your changes.

Matth-- reacted with thumbs up emoji

@Matth--Matth--force-pushed thefix/user-provider-listener branch from0a713f2 to46bdeb8CompareJune 2, 2021 19:07
@nicolas-grekas
Copy link
Member

Thank you@Matth--.

Matth-- reacted with rocket emoji

@nicolas-grekasnicolas-grekas merged commit1ec9a83 intosymfony:5.2Jun 3, 2021
@Matth--Matth-- deleted the fix/user-provider-listener branchJune 3, 2021 16:53
@Matth--Matth-- restored the fix/user-provider-listener branchJune 3, 2021 16:54
@Matth--Matth-- deleted the fix/user-provider-listener branchJune 3, 2021 16:54
@fabpotfabpot mentioned this pull requestJun 17, 2021
@fabpotfabpot mentioned this pull requestJun 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@chalasrchalasrchalasr approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

[Security][Authenticator-based] Multiple providers

6 participants

@Matth--@nicolas-grekas@derrabus@stof@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp