Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Readd deprecated methods to the interfaces#41493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromwouterj:issue-41470/username-bc
Jun 2, 2021

Conversation

@wouterj
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41470
LicenseMIT
Doc PRn/a

Readd the deprecated methods to the interface, to make sure third party packages <5.3 work with objects created using the 5.3+ interfaces.

I've tested in a project and the deprecation is not triggered when implementing the method, only when calling. So this should still allow applications to be deprecation free in 5.4.

dereuromark, pamil, and VincentLanglet reacted with thumbs up emojidereuromark, pamil, and scheb reacted with heart emoji
wouterj added a commit to wouterj/maker-bundle that referenced this pull requestJun 1, 2021
@wouterjwouterjforce-pushed theissue-41470/username-bc branch fromb462bc3 toc23455eCompareJune 1, 2021 13:31
@wouterjwouterjforce-pushed theissue-41470/username-bc branch fromf1285f4 tob024656CompareJune 1, 2021 15:43
alongosz added a commit to ezsystems/ezplatform-kernel that referenced this pull requestJun 2, 2021
For more details seesymfony/symfony#41493Additionally removed symfony/cache conflicts as they no longer apply(we're requiring ^5.2.0)
@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commite6510a0 intosymfony:5.3Jun 2, 2021
@wouterjwouterj deleted the issue-41470/username-bc branchJune 2, 2021 09:35
@fabpotfabpot mentioned this pull requestJun 2, 2021
@Pixelshaped
Copy link

In my User I had to readd the old method:

    /**     * A visual identifier that represents this user.     *     * @see UserInterface     */    public function getUserIdentifier(): string    {        return (string) $this->email;    }    /**     * @deprecated in Symfony 5.3     */    public function getUsername(): string    {        return $this->getUserIdentifier();    }

As I understand it, I could remove the new method that will be re-introduced for the 6.0 BC?

@stof
Copy link
Member

stof commentedJun 2, 2021

yeah, thegetUsername will be removed from the interface in 6.0 (and so you will be able to remove it from your class implementing the interface). Deprecation-free code won't use this method in 5.3+ (usinggetUserIdentifier instead)

@derrabus
Copy link
Member

As I understand it, I could remove the new method that will be re-introduced for the 6.0 BC?

Don't remove the new method. Keep both methods for now and dropgetUsername() once you migrate to Symfony 6.

jrushlow pushed a commit to wouterj/maker-bundle that referenced this pull requestJun 6, 2021
jrushlow pushed a commit to wouterj/maker-bundle that referenced this pull requestJun 8, 2021
weaverryan added a commit to symfony/maker-bundle that referenced this pull requestJun 18, 2021
…outerj, weaverryan)This PR was merged into the 1.0-dev branch.Discussion----------[make:user] Keep implementing deprecated username methodsThis updates the makers forsymfony/symfony#41493 (where these methods are reintroduced to the interface for 5.3.1)Commits-------2d9312e Fix testsbd55d19 Update src/Resources/skeleton/security/UserProvider.tpl.phpc3d4046 Still implement deprecated username method
saylor-mik87786 added a commit to saylor-mik87786/maker-bundle that referenced this pull requestJun 3, 2025
saylor-mik87786 added a commit to saylor-mik87786/maker-bundle that referenced this pull requestJun 3, 2025
…outerj, weaverryan)This PR was merged into the 1.0-dev branch.Discussion----------[make:user] Keep implementing deprecated username methodsThis updates the makers forsymfony/symfony#41493 (where these methods are reintroduced to the interface for 5.3.1)Commits-------2d9312e0 Fix testsbd55d199 Update src/Resources/skeleton/security/UserProvider.tpl.phpc3d40460 Still implement deprecated username method
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

+1 more reviewer

@pamilpamilpamil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

8 participants

@wouterj@fabpot@Pixelshaped@stof@derrabus@pamil@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp