Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Always dump the container as XML#41457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Dumping the container as XML in prod too prevents compiling it twice oncache:warmup, when egConfigBuilderCacheWarmer runs, or whendebug:container ordebug:router run.

@nicolas-grekasnicolas-grekas added this to the5.3 milestoneMay 31, 2021
@carsonbotcarsonbot changed the title[FrameworkBundle] Always dump the container as XMLAlways dump the container as XMLMay 31, 2021
@carsonbotcarsonbot changed the titleAlways dump the container as XML[FrameworkBundle] Always dump the container as XMLMay 31, 2021
@nicolas-grekas
Copy link
MemberAuthor

Closing as that's not required to preventConfigBuilderCacheWarmer from compiling twice.

@nicolas-grekasnicolas-grekas deleted the always-dump branchMay 31, 2021 10:02
@Nyholm
Copy link
Member

Could you elaborate? With this PR,Kernel::buildContainer() is only called once onbin/console cache:clear.

@nicolas-grekas
Copy link
MemberAuthor

See#41458

@nicolas-grekas
Copy link
MemberAuthor

Note that we could decide to reopen this PR and merge it in 5.4, but that'd need a dedicated discussion.
#41458 fixes the root issue I was hunting.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@Nyholm@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp