Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Provide migration path for TestSessionListener#41446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromjderusse:session_path
Jun 1, 2021

Conversation

@jderusse
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

When working on#41321 I realized that#41343 was wrong forTestSessionListener.
Injecting the factory in both SessionListener AND TestSessionListener would generate 2 distinguished session instances which is the opposite of the expected behavior: TestSessionListener needs the session used by the request to set the right sessionId in the cookie.

This PR fallback torequest->getSession() when there is no session injected in the container (ie: FrameworkBundlke:6)

@carsonbotcarsonbot changed the title[HttpKernel] Provide migration path for TestSessionListenerProvide migration path for TestSessionListenerMay 29, 2021
@carsonbotcarsonbot changed the titleProvide migration path for TestSessionListener[HttpKernel] Provide migration path for TestSessionListenerMay 29, 2021
@derrabusderrabus added this to the5.4 milestoneMay 30, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This topic is a can of worms :)
inSessionListener, shouldn't we update line 41?

@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commit7714648 intosymfony:5.4Jun 1, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jderusse@nicolas-grekas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp