Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Improved the light/dark theme switching#41432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark commentedMay 29, 2021
I would go with a bugfix based on your explanation |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base.html.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/settings.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedMay 31, 2021
The title says it all, it's an improvement, so this should target 5.4. |
c93f986 tof5e19a1Comparejaviereguiluz commentedMay 31, 2021
Rebased to 5.4. Thanks! |
javiereguiluz commentedJun 23, 2021
Please, tell me if I should make any other change or improvement here. Thanks! |
fabpot commentedJun 23, 2021
Thank you@javiereguiluz. |
Uh oh!
There was an error while loading.Please reload this page.
Note: I think this is a bug fix ... but maybe you prefer to consider it a new feature.The current Symfony Profiler works like this:
The problem is that when you choose a theme explicitly, the "auto" theme is no longer available. You need to delete the local storage of your browser.
This PR makes it explicit the "auto theme" already available in the Profiler. That way, you can set "light", "dark" or "auto" explicitly:
It also changes the "theme listener" to respond instantly to OS changes, without having to refresh the page.