Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Improved the light/dark theme switching#41432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromjaviereguiluz:profiler_auto_theme
Jun 23, 2021

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluzjaviereguiluz commentedMay 28, 2021
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Note: I think this is a bug fix ... but maybe you prefer to consider it a new feature.


The current Symfony Profiler works like this:

  • If you don't set the theme, it selects it automatically form light/dark to match your OS
  • But you can also select "light" or "dark" explicitly

The problem is that when you choose a theme explicitly, the "auto" theme is no longer available. You need to delete the local storage of your browser.

This PR makes it explicit the "auto theme" already available in the Profiler. That way, you can set "light", "dark" or "auto" explicitly:

Captura de pantalla 2021-05-28 a las 11 01 21

It also changes the "theme listener" to respond instantly to OS changes, without having to refresh the page.

OskarStark and jvasseur reacted with thumbs up emojiOskarStark reacted with heart emoji
@OskarStark
Copy link
Contributor

I would go with a bugfix based on your explanation

derrabus reacted with thumbs up emoji

@fabpot
Copy link
Member

The title says it all, it's an improvement, so this should target 5.4.

javiereguiluz reacted with thumbs up emoji

@javiereguiluz
Copy link
MemberAuthor

Rebased to 5.4. Thanks!

@javiereguiluz
Copy link
MemberAuthor

Please, tell me if I should make any other change or improvement here. Thanks!

@fabpot
Copy link
Member

Thank you@javiereguiluz.

@fabpotfabpot merged commit25c9bd3 intosymfony:5.4Jun 23, 2021
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@wouterjwouterjwouterj approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@OskarStark@fabpot@stof@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp