Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] Leverage array_is_list()#41431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromnicolas-grekas:array-list
Jun 2, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMay 28, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lovely 😍

@Nyholm
Copy link
Member

Is this really a bugfix?

Ie, why not target 5.4?

@nicolas-grekas
Copy link
MemberAuthor

To save some potential merge conflicts, and benefit from the work on the polyfill I guess.

derrabus reacted with thumbs up emoji

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is consistent with the way we introduced usage ofget_debug_type where we relied on the polyfill in older branches too.

@nicolas-grekas
Copy link
MemberAuthor

this is consistent with the way we introduced usage of get_debug_type where we relied on the polyfill in older branches too.

ooch, actually we addedget_debug_type() only on recent branches! That reverses the argument, updating for 5.4... :)

@nicolas-grekasnicolas-grekas changed the base branch from4.4 to5.4June 1, 2021 10:05
@nicolas-grekasnicolas-grekas modified the milestones:4.4,5.4Jun 1, 2021
@nicolas-grekasnicolas-grekas merged commit2fe4442 intosymfony:5.4Jun 2, 2021
@nicolas-grekasnicolas-grekas deleted the array-list branchJune 3, 2021 14:12
fabpot added a commit that referenced this pull requestNov 5, 2021
…s (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[Yaml] revert using functions provided by polyfill packages| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#43943| License       | MIT| Doc PR        |This reverts#41431 for the same reason for which we merged#42296 (see#42280 andcomposer/composer#10024 for more information).Commits-------3b9b700 revert using functions provided by polyfill packages
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@Nyholm@javiereguiluz@stof@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp