Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add union types#41424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
nicolas-grekas wants to merge1 commit intosymfony:6.0fromnicolas-grekas:unions
Closed

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMay 27, 2021•
edited
Loading

QA
Branch?6.0
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Created usinghttps://github.com/rectorphp/rector/ and manual editing (a lot of them. ;))

For the record, I'm using this command to inspect a specific component:
grep -l 'function [a-zA-Z_].*(\([$]\|.*, [$]\)' -- $(find src/Symfony/Component/Messenger -type f|grep Tests -v)

  • src/Symfony/Bridge/Doctrine/
  • src/Symfony/Bridge/Monolog/
  • src/Symfony/Bridge/ProxyManager/
  • src/Symfony/Bridge/Twig/
  • src/Symfony/Bundle/DebugBundle/
  • src/Symfony/Bundle/FrameworkBundle/
  • src/Symfony/Bundle/SecurityBundle/
  • src/Symfony/Bundle/TwigBundle/
  • src/Symfony/Bundle/WebProfilerBundle/
  • src/Symfony/Component/Asset/
  • src/Symfony/Component/BrowserKit/
  • src/Symfony/Component/Cache/
  • src/Symfony/Component/Config/
  • src/Symfony/Component/CssSelector/
  • src/Symfony/Component/Console/
  • src/Symfony/Component/DependencyInjection/
  • src/Symfony/Component/DomCrawler/
  • src/Symfony/Component/Dotenv/
  • src/Symfony/Component/ErrorHandler/
  • src/Symfony/Component/EventDispatcher/
  • src/Symfony/Component/ExpressionLanguage/
  • src/Symfony/Component/Form/
  • src/Symfony/Component/Filesystem/
  • src/Symfony/Component/Finder/
  • src/Symfony/Component/HttpClient/
  • src/Symfony/Component/HttpFoundation/
  • src/Symfony/Component/HttpKernel/
  • src/Symfony/Component/Intl/
  • src/Symfony/Component/Ldap/
  • src/Symfony/Component/Lock/
  • src/Symfony/Component/Mailer/
  • src/Symfony/Component/Messenger/
  • src/Symfony/Component/Mime/
  • src/Symfony/Component/Notifier/
  • src/Symfony/Component/OptionsResolver/
  • src/Symfony/Component/PasswordHasher/
  • src/Symfony/Component/Process/
  • src/Symfony/Component/PropertyAccess/
  • src/Symfony/Component/PropertyInfo/
  • src/Symfony/Component/RateLimiter/
  • src/Symfony/Component/Routing/
  • src/Symfony/Component/Runtime/
  • src/Symfony/Component/Security/
  • src/Symfony/Component/Semaphore/
  • src/Symfony/Component/Serializer/
  • src/Symfony/Component/Stopwatch/
  • src/Symfony/Component/String/
  • src/Symfony/Component/Templating/
  • src/Symfony/Component/Translation/
  • src/Symfony/Component/Uid/
  • src/Symfony/Component/Validator/
  • src/Symfony/Component/VarDumper/
  • src/Symfony/Component/VarExporter/
  • src/Symfony/Component/WebLink/
  • src/Symfony/Component/Workflow/
  • src/Symfony/Component/Yaml/
  • src/Symfony/Contracts/

kevin-emo, GromNaN, and ging-dev reacted with thumbs up emojijaviereguiluz, dunglas, Guikingone, simon-schubert, OskarStark, sstok, kevin-emo, and tarlepp reacted with hooray emojijaviereguiluz, Guikingone, and kevin-emo reacted with heart emojikevin-emo and Moilamar reacted with rocket emojiKocal, ostrolucky, tarlepp, and nemoipaha reacted with eyes emoji
@kaznovac
Copy link
Contributor

just minor consistency some union definitions have spaces around the pipe character, but some don't

@ro0NL
Copy link
Contributor

is there a CS rule?

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fyi, I've reviewed up to the Console component.

This PR does not only introduce union types, but also someobject,string andbool types. Is that intended?

* @return array|null Array with important QueryBuilder parts or null if
* they can't be determined
*
* @internal This method is public to be usable as callback. It should not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unrelated, but this one, the one above and the one in EntityType below can also be madeprivate in Symfony 5.4 I think. The requiredpublic visibility is from 6 years ago, when$this inside a closure was not yet supported (3172d73).

Copy link
MemberAuthor

@nicolas-grekasnicolas-grekasMay 27, 2021•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

correct, anyone up for a PR doing so?

@nicolas-grekas
Copy link
MemberAuthor

Thank you all and@wouterj especially for the review. This is going to take ages to get right. The more eyes the better :)

sstok reacted with eyes emoji

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some more :)

@nicolas-grekasnicolas-grekasforce-pushed theunions branch 3 times, most recently fromfab0860 to141fdecCompareMay 28, 2021 15:08
nicolas-grekas added a commit that referenced this pull requestMay 28, 2021
This PR was merged into the 6.0 branch.Discussion----------[Yaml] add types to all arguments| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Extracted from#41424Commits-------129411e [Yaml] add types to all arguments
nicolas-grekas added a commit that referenced this pull requestMay 28, 2021
This PR was merged into the 6.0 branch.Discussion----------[Workflow] add types to all arguments| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Extracted from#41424Commits-------6a94b77 [Workflow] add types to all arguments
nicolas-grekas added a commit that referenced this pull requestMay 28, 2021
This PR was merged into the 6.0 branch.Discussion----------[VarDumper] add types to all arguments| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Extracted from#41424Commits-------e68b368 [VarDumper] add types to all arguments
nicolas-grekas added a commit that referenced this pull requestJun 29, 2021
This PR was merged into the 6.0 branch.Discussion----------Add more types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Related to#41424Commits-------c21a7be Add more types
nicolas-grekas added a commit that referenced this pull requestJun 29, 2021
This PR was merged into the 6.0 branch.Discussion----------[Config] Add parameter types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | N/AThis PR adds parameter types to all methods of the Config component.Commits-------e7e5256 [Config] Add parameter types
nicolas-grekas added a commit that referenced this pull requestJun 29, 2021
This PR was merged into the 6.0 branch.Discussion----------[DependencyInjection] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------e017977 [DependencyInjection] add union types
nicolas-grekas added a commit that referenced this pull requestJun 30, 2021
This PR was merged into the 6.0 branch.Discussion----------[HttpFoundation] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------9f4a5fb [HttpFoundation] add union types
@nicolas-grekasnicolas-grekasforce-pushed theunions branch 3 times, most recently fromd4dc8b1 tofc6fa3aCompareJune 30, 2021 16:21
nicolas-grekas added a commit that referenced this pull requestJul 1, 2021
This PR was merged into the 6.0 branch.Discussion----------[FrameworkBundle] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------e85e459 [FrameworkBundle] add union types
nicolas-grekas added a commit that referenced this pull requestJul 1, 2021
This PR was merged into the 6.0 branch.Discussion----------[Security] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------24e042c [Security] add union types
nicolas-grekas added a commit that referenced this pull requestJul 1, 2021
This PR was merged into the 6.0 branch.Discussion----------[Serializer] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------4db6d56 [Serializer] add union types
nicolas-grekas added a commit that referenced this pull requestJul 2, 2021
This PR was merged into the 6.0 branch.Discussion----------[Console] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------66b6865 [Console] add union types
@nicolas-grekas
Copy link
MemberAuthor

Closing as the only remaining changes are for Cache, and there is already#41290.
Tasks completed 🎉

sstok reacted with hooray emoji

@nicolas-grekasnicolas-grekas deleted the unions branchJuly 6, 2021 09:02
nicolas-grekas added a commit that referenced this pull requestJul 7, 2021
This PR was merged into the 6.0 branch.Discussion----------[Cache] Leverage union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------3275859 [Cache] Leverage union types
nicolas-grekas added a commit that referenced this pull requestJul 7, 2021
This PR was squashed before being merged into the 6.0 branch.Discussion----------[Form] add union types| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | Part of#41424| License       | MIT| Doc PR        | -Commits-------0480be6 [Form] add union types
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@derrabusderrabusderrabus left review comments

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

@jderussejderusseAwaiting requested review from jderusse

+3 more reviewers

@kaznovackaznovackaznovac left review comments

@WarxcellWarxcellWarxcell left review comments

@VincentLangletVincentLangletVincentLanglet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Help wantedIssues and PRs which are looking for volunteers to complete them.Status: Needs Review

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

10 participants

@nicolas-grekas@kaznovac@ro0NL@tarlepp@derrabus@xabbuh@wouterj@Warxcell@VincentLanglet@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp