Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Throw when HttpKernel is created and the env is empty#41402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromnicolas-grekas:hk-empty-env
May 24, 2021

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Providing an empty env leads to an undefined behavior, better forbid it. This will fail at compile time, so it should be safe; but still submitting on 5.3 for extra safety.

@nicolas-grekasnicolas-grekas changed the title[HttpKernel] Throw when HttpKernel is create and the env is empty[HttpKernel] Throw when HttpKernel is created and the env is emptyMay 24, 2021
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit7e9dbec intosymfony:5.3May 24, 2021
@nicolas-grekasnicolas-grekas deleted the hk-empty-env branchMay 27, 2021 13:00
@fabpotfabpot mentioned this pull requestMay 31, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp