Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mime] Removes tests for code that has been deleted#41398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@0x346e3730
Copy link
Contributor

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsNone
LicenseMIT
Doc PRNot a new feature

This PR fixes tests on the MIME component after a deprecated method was removed on the 6.0 branch by the PR#41364

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

This should be applied on 5.2, I think, as the code in 5.2 should not call any deprecated codepath.

@nicolas-grekas
Copy link
Member

Oh wait, no! The tests cases should be remove instead, that's why they're marked asgroup legacy.!

@0x346e3730
Copy link
ContributorAuthor

I'll update asap to remove the tests, nice catch

@0x346e37300x346e3730 changed the title[Mime] Fixes tests for the MIME component[Mime] Removes tests for code that has been deletedMay 24, 2021
@0x346e3730
Copy link
ContributorAuthor

Closing in favor of#41404.

Nyholm added a commit that referenced this pull requestMay 25, 2021
This PR was merged into the 6.0 branch.Discussion----------[Mime] Removes deprecated tests| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -Follow-up from#41398 to fix CI for 6.0.Commits-------cc358f4 [Mime] Removes deprecated tests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0x346e3730@carsonbot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp