Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mime] Removes tests for code that has been deleted#41398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 24, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedMay 24, 2021
This should be applied on 5.2, I think, as the code in 5.2 should not call any deprecated codepath. |
nicolas-grekas commentedMay 24, 2021
Oh wait, no! The tests cases should be remove instead, that's why they're marked as |
0x346e3730 commentedMay 24, 2021
I'll update asap to remove the tests, nice catch |
0x346e3730 commentedMay 24, 2021
Closing in favor of#41404. |
This PR was merged into the 6.0 branch.Discussion----------[Mime] Removes deprecated tests| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Follow-up from#41398 to fix CI for 6.0.Commits-------cc358f4 [Mime] Removes deprecated tests
This PR fixes tests on the MIME component after a deprecated method was removed on the 6.0 branch by the PR#41364