Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] fix support for years outside of the 32b range on x86 arch#41394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMay 24, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
b0588de toac4f715Compare| ->method('loadTokenBySeries') | ||
| ->with('series1') | ||
| ->willReturn(newPersistentToken(InMemoryUser::class,'wouter','series1','tokenvalue',new \DateTime('-'.(31536000 -1).'years'))); | ||
| ->willReturn(newPersistentToken(InMemoryUser::class,'wouter','series1','tokenvalue',new \DateTime('-'.(31536000 -1).'months'))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
/cc@wouterj WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To me, seems like we can even make this'-'.(31536000 + 1).' seconds'?
| thrownewMethodArgumentValueNotImplementedException(__METHOD__,'timestamp',$timestamp,$message); | ||
| } | ||
| if (\is_string($timestamp) &&$dt = \DateTime::createFromFormat('U',$timestamp)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should also be applied to the polyfills repo, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yep, seesymfony/polyfill#357
…86 arch on PHP 8.4 (nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[Yaml] fix support for years outside of the 32b range on x86 arch on PHP 8.4| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITSimilar to#41394 but for PHP 8.4Commits-------c2f9a7c [Yaml] fix support for years outside of the 32b range on x86 arch on PHP 8.4