Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove deprecatedUser from serialized test fixture#41385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

@derrabusderrabus commentedMay 23, 2021•
edited
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

SwitchUserTokenTest tests if a token serialized with Symfony 4.4 can still be unserialized. The serialized fixture however used the now-deprecatedSymfony\Component\Security\Core\User\User. This PR replaces that class with a new custom user class, which should make the test more resilient.

@carsonbotcarsonbot added this to the5.3 milestoneMay 23, 2021
@derrabusderrabus changed the titleRemove deprecated User from serialized test fixtureRemove deprecatedUser from serialized test fixtureMay 23, 2021
@chalasr
Copy link
Member

chalasr commentedMay 23, 2021•
edited
Loading

Oh... I was pretty sure that this fixture was already upgraded in a PR of mine on 5.3 but actually, the upgraded fixture ended up in the wrong directory (1 level up):https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/Security/Core/Tests/Authentication/Token/switch-user-token-4.4.txt
Can you please remove this unused file?

derrabus reacted with thumbs up emoji

@derrabusderrabusforce-pushed thebugfix/switch-user-token branch from3f3544b toba2ae4eCompareMay 23, 2021 16:27
@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit27fef51 intosymfony:5.3May 23, 2021
@derrabusderrabus deleted the bugfix/switch-user-token branchMay 23, 2021 16:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus@chalasr@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp