Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix SkippedTestSuite#41384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromjderusse:fix-skipped-suite
Jul 4, 2021
Merged

Conversation

@jderusse
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Throwing a TestSkipped in asetUpBeforeClass si handled by PHP unit as a standard exception, leading to a generic exceptionTest skipped because of an error in hook method (seehttps://github.com/symfony/symfony/pull/41380/checks?check_run_id=2645369759#step:14:165)

However phpunit is able to catchSkippedTestSuiteError in such situation.(https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestSuite.php#L438-L448)

This PR replacesself::markTestSkipped bythrow new SkippedTestSuiteError (we don't have static method helper for this exception) in oursetUpBeforeClass methods.

@jderussejderusse changed the base branch from5.4 to4.4May 23, 2021 13:18
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneMay 26, 2021
@nicolas-grekas
Copy link
Member

But this method is now@internal. Maybe we should report this to phpunit before?

@jderusse
Copy link
MemberAuthor

Issue opened insebastianbergmann/phpunit#4689

@fabpot
Copy link
Member

As there is no feedback upstream, can we merge this one in the meantime?

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's go

@fabpot
Copy link
Member

Thank you@jderusse.

1 similar comment
@fabpot
Copy link
Member

Thank you@jderusse.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jderusse@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp