Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyAccess] Remove deprecated code#41365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[PropertyAccess] Remove deprecated code#41365
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 22, 2021
Hey! I think@HeahDude has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
| */ | ||
| publicfunctiontestGetValueReturnsNullIfPropertyNotFoundAndExceptionIsDisabledUsingBooleanArgument($objectOrArray,$path) | ||
| { | ||
| $this->expectDeprecation('Since symfony/property-access 5.3: Passing a boolean as the fourth argument to "Symfony\Component\PropertyAccess\PropertyAccessor::__construct()" is deprecated. Pass a combination of bitwise flags as the second argument instead (i.e an integer).'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please also removeExpectDeprecationTrait from this test:
| useSymfony\Bridge\PhpUnit\ExpectDeprecationTrait; |
| publicfunction__construct(int$magicMethods =self::MAGIC_GET |self::MAGIC_SET,int$throw =self::THROW_ON_INVALID_PROPERTY_PATH,CacheItemPoolInterface$cacheItemPool =null,PropertyReadInfoExtractorInterface$readInfoExtractor =null,PropertyWriteInfoExtractorInterface$writeInfoExtractor =null) | ||
| { | ||
| if (\is_bool($magicMethods)) { | ||
| trigger_deprecation('symfony/property-access','5.2','Passing a boolean as the first argument to "%s()" is deprecated. Pass a combination of bitwise flags instead (i.e an integer).',__METHOD__); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can removesymfony/deprecation-contracts from the composer.json file. See#41298 (comment)
jschaedl commentedMay 23, 2021
Shall we update the component's CHANGELOG file accordingly? |
nicolas-grekas commentedMay 23, 2021
yes please, please also rebase and take review comments into account of course |
nicolas-grekas commentedMay 27, 2021
Please rebase to restart tests 🙏 |
nicolas-grekas commentedMay 27, 2021
Thank you@malteschlueter. |
This remove deprecated code from PropertyAccess.