Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Fix compatibility with Symfony6#41343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromjderusse:deprec-session-path
May 27, 2021

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedMay 20, 2021•
edited by nicolas-grekas
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Thesession service will be removed in FrameworkBundle 6, this PR make sure the session listener 5.4 will be compatible with FrameworkBundle 6.0

@nicolas-grekas
Copy link
Member

For 5.3?

@jderussejderusse changed the base branch from5.4 to5.3May 20, 2021 18:30
@jderusse
Copy link
MemberAuthor

For 5.3?

Rebased.. But 5.3 is not compatible with FWB 6.0

@jderussejderusse added this to the5.3 milestoneMay 20, 2021
@jderussejderusse changed the titleFix compatibility with Symfony 6.0[HttpKernel] Fix compatibility with Symfony 6.0May 21, 2021
@nicolas-grekas
Copy link
Member

Rebased.. But 5.3 is not compatible with FWB 6.0

OK, then let's go on 5.4. Don't miss adding changelog+upgrade files entries.

@nicolas-grekasnicolas-grekas modified the milestones:5.3,5.4May 21, 2021
@carsonbotcarsonbot changed the title[HttpKernel] Fix compatibility with Symfony 6.0Fix compatibility with Symfony 6.0May 21, 2021
@carsonbotcarsonbot changed the titleFix compatibility with Symfony 6.0[HttpKernel] Fix compatibility with Symfony 6.0May 21, 2021
@carsonbotcarsonbot changed the title[HttpKernel] Fix compatibility with Symfony 6.0[FrameworkBundle][HttpKernel] Fix compatibility with Symfony 6.0May 21, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(blocking until proposal is discussed)

@jderussejderusseforce-pushed thedeprec-session-path branch 2 times, most recently froma9e3e16 toda40387CompareMay 24, 2021 06:18
@jderussejderusse changed the title[FrameworkBundle][HttpKernel] Fix compatibility with Symfony 6.0[HttpKernel] Mark SessionListener InternalMay 24, 2021
@jderussejderusseforce-pushed thedeprec-session-path branch 2 times, most recently fromff8b9fb tob317830CompareMay 24, 2021 07:05
@nicolas-grekasnicolas-grekas changed the title[HttpKernel] Mark SessionListener Internal[HttpKernel] Fix compatibility with Symfony6May 25, 2021
@carsonbotcarsonbot changed the title[HttpKernel] Fix compatibility with Symfony6[HttpKernel] Fix compatibility with Symfony6May 25, 2021
@nicolas-grekas
Copy link
Member

Thank you@jderusse.

@nicolas-grekasnicolas-grekas merged commitcfb1016 intosymfony:5.4May 27, 2021
nicolas-grekas added a commit that referenced this pull requestJun 1, 2021
…r (jderusse)This PR was merged into the 5.4 branch.Discussion----------[HttpKernel] Provide migration path for TestSessionListener| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -When working on#41321 I realized that#41343 was wrong for `TestSessionListener`.Injecting the factory in both SessionListener AND TestSessionListener would generate 2 distinguished session instances which is the opposite of the expected behavior: TestSessionListener needs the session used by the request to set the right sessionId in the cookie.This PR fallback to `request->getSession()` when there is no session injected in the container (ie: FrameworkBundlke:6)Commits-------b56606e Provide migration path for TestSessionListener
@jderussejderusse deleted the deprec-session-path branchSeptember 4, 2021 23:04
nicolas-grekas added a commit that referenced this pull requestSep 7, 2021
…erusse)This PR was merged into the 6.0 branch.Discussion----------[FrameworkBundle] Remove deprecate session service| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -To ease code review this PR only removes code for session.Blocked by#41343Commits-------9e6a3d3 Remove deprecate session service
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@srozesrozeAwaiting requested review from sroze

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

+1 more reviewer

@KocalKocalKocal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@jderusse@nicolas-grekas@derrabus@Kocal@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp