Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] remove deprecated code#41334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
0e0d078 to6e74e9bComparecarsonbot commentedMay 21, 2021
Hey! I think@pyrech has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
azjezz commentedMay 21, 2021
RFR, failure is unrelated. |
| * InputBag is a container for user input values such as $_GET, $_POST, $_REQUEST, and $_COOKIE. | ||
| * | ||
| * @author Saif Eddin Gmati <saif.gmati@symfony.com> | ||
| * @author Saif Eddin Gmati <azjezz@protonmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please submit this change on 5.2
| * @return string|int|float|bool|null | ||
| */ | ||
| publicfunctionget(string$key,$default =null) | ||
| publicfunctionget(string$key,$default =null):string |int |float |bool |null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
reverting as adding return types is a separate topic
| trigger_deprecation('symfony/http-foundation','5.2','The "HEADER_X_FORWARDED_ALL" constant is deprecated, use either "HEADER_X_FORWARDED_FOR | HEADER_X_FORWARDED_HOST | HEADER_X_FORWARDED_PORT | HEADER_X_FORWARDED_PROTO" or "HEADER_X_FORWARDED_AWS_ELB" or "HEADER_X_FORWARDED_TRAEFIK" constants instead.'); | ||
| } | ||
| self::$trustedProxies =array_reduce($proxies,function ($proxies,$proxy) { | ||
| self::$trustedProxies =array_reduce($proxies,staticfunction ($proxies,$proxy) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
reverting as this might create needles merge conflicts and is not needed: the surrounding method is already static, so is this closure.
Signed-off-by: azjezz <azjezz@protonmail.com>
0f7f3bc to8312f90Comparenicolas-grekas commentedMay 23, 2021
Thank you@azjezz. |
…obion)This PR was merged into the 6.0 branch.Discussion----------[HttpFoundation] remove legacy session lifetime logic| Q | A| ------------- | ---| Branch? | 6.0| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets || License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This part was only relevant for keeping bc with the old lifetime data. Has been forgotten to be removed in#41334 and#43120Commits-------54a578b [HttpFoundation] remove legacy session lifetime logic
Uh oh!
There was an error while loading.Please reload this page.